Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 9fa1aaa

Browse files
committed
Add missing BUFFERS OFF in select_into regression tests
c2a4078 adjusted EXPLAIN ANALYZE to include BUFFERS by default, but a few tests in select_into.sql neglected to add BUFFERS OFF. The failing tests seem unlikely to ever access buffers during execution, but they certainly could during planning. Per buildfarm member kestrel, tayra and calliphoridae. Discussion: https://postgr.es/m/CANNMO++W7MM8T0KyXN3ZheXXt-uLVM3aEtZd+WNfZ=obxffUiA@mail.gmail.com
1 parent c2a4078 commit 9fa1aaa

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

src/test/regress/expected/select_into.out

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF, BUFFERS OFF)
3737
-- WITH NO DATA, passes.
3838
CREATE TABLE selinto_schema.tbl_nodata1 (a) AS
3939
SELECT generate_series(1,3) WITH NO DATA;
40-
EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF)
40+
EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF, BUFFERS OFF)
4141
CREATE TABLE selinto_schema.tbl_nodata2 (a) AS
4242
SELECT generate_series(1,3) WITH NO DATA;
4343
QUERY PLAN
@@ -50,7 +50,7 @@ EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF)
5050
PREPARE data_sel AS SELECT generate_series(1,3);
5151
CREATE TABLE selinto_schema.tbl_withdata3 (a) AS
5252
EXECUTE data_sel WITH DATA;
53-
EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF)
53+
EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF, BUFFERS OFF)
5454
CREATE TABLE selinto_schema.tbl_withdata4 (a) AS
5555
EXECUTE data_sel WITH DATA;
5656
QUERY PLAN

src/test/regress/sql/select_into.sql

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,14 +36,14 @@ EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF, BUFFERS OFF)
3636
-- WITH NO DATA, passes.
3737
CREATE TABLE selinto_schema.tbl_nodata1 (a) AS
3838
SELECT generate_series(1,3) WITH NO DATA;
39-
EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF)
39+
EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF, BUFFERS OFF)
4040
CREATE TABLE selinto_schema.tbl_nodata2 (a) AS
4141
SELECT generate_series(1,3) WITH NO DATA;
4242
-- EXECUTE and WITH DATA, passes.
4343
PREPARE data_sel AS SELECT generate_series(1,3);
4444
CREATE TABLE selinto_schema.tbl_withdata3 (a) AS
4545
EXECUTE data_sel WITH DATA;
46-
EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF)
46+
EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF, BUFFERS OFF)
4747
CREATE TABLE selinto_schema.tbl_withdata4 (a) AS
4848
EXECUTE data_sel WITH DATA;
4949
-- EXECUTE and WITH NO DATA, passes.

0 commit comments

Comments
 (0)