Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit a0390f6

Browse files
committed
Review wording on tablespaces w.r.t. partitioned tables
Remove a redundant comment, and document pg_class.reltablespace properly in catalogs.sgml. After commits a36c84c, 8725958 and others. Backpatch to 12. Discussion: https://postgr.es/m/202403191013.w2kr7wqlamqz@alvherre.pgsql
1 parent da952b4 commit a0390f6

File tree

2 files changed

+6
-7
lines changed

2 files changed

+6
-7
lines changed

doc/src/sgml/catalogs.sgml

+6-3
Original file line numberDiff line numberDiff line change
@@ -2011,9 +2011,12 @@ SCRAM-SHA-256$<replaceable>&lt;iteration count&gt;</replaceable>:<replaceable>&l
20112011
(references <link linkend="catalog-pg-tablespace"><structname>pg_tablespace</structname></link>.<structfield>oid</structfield>)
20122012
</para>
20132013
<para>
2014-
The tablespace in which this relation is stored. If zero,
2015-
the database's default tablespace is implied. (Not meaningful
2016-
if the relation has no on-disk file.)
2014+
The tablespace in which this relation is stored.
2015+
If zero, the database's default tablespace is implied.
2016+
Not meaningful if the relation has no on-disk file,
2017+
except for partitioned tables, where this is the tablespace
2018+
in which partitions will be created when one is not
2019+
specified in the creation command.
20172020
</para></entry>
20182021
</row>
20192022

src/backend/commands/tablecmds.c

-4
Original file line numberDiff line numberDiff line change
@@ -807,10 +807,6 @@ DefineRelation(CreateStmt *stmt, char relkind, Oid ownerId,
807807
}
808808
else if (stmt->partbound)
809809
{
810-
/*
811-
* For partitions, when no other tablespace is specified, we default
812-
* the tablespace to the parent partitioned table's.
813-
*/
814810
Assert(list_length(inheritOids) == 1);
815811
tablespaceId = get_rel_tablespace(linitial_oid(inheritOids));
816812
}

0 commit comments

Comments
 (0)