Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit a20aac8

Browse files
committed
Temporarily revert test case from a2b70c8.
That code patch was good as far as it went, but the associated test case has exposed fundamental brain damage in the parallel scan mechanism, which is going to take nontrivial work to correct. In the interests of getting the buildfarm back to green so that unrelated work can proceed, let's temporarily remove the test case.
1 parent 54cde0c commit a20aac8

File tree

2 files changed

+0
-59
lines changed

2 files changed

+0
-59
lines changed

src/test/regress/expected/select_parallel.out

-43
Original file line numberDiff line numberDiff line change
@@ -300,49 +300,6 @@ select count(*) from tenk1 group by twenty;
300300
500
301301
(20 rows)
302302

303-
--test rescan behavior of gather merge
304-
set enable_material = false;
305-
explain (costs off)
306-
select * from
307-
(select string4, count(unique2)
308-
from tenk1 group by string4 order by string4) ss
309-
right join (values (1),(2),(3)) v(x) on true;
310-
QUERY PLAN
311-
----------------------------------------------------------
312-
Nested Loop Left Join
313-
-> Values Scan on "*VALUES*"
314-
-> Finalize GroupAggregate
315-
Group Key: tenk1.string4
316-
-> Gather Merge
317-
Workers Planned: 4
318-
-> Partial GroupAggregate
319-
Group Key: tenk1.string4
320-
-> Sort
321-
Sort Key: tenk1.string4
322-
-> Parallel Seq Scan on tenk1
323-
(11 rows)
324-
325-
select * from
326-
(select string4, count(unique2)
327-
from tenk1 group by string4 order by string4) ss
328-
right join (values (1),(2),(3)) v(x) on true;
329-
string4 | count | x
330-
---------+-------+---
331-
AAAAxx | 2500 | 1
332-
HHHHxx | 2500 | 1
333-
OOOOxx | 2500 | 1
334-
VVVVxx | 2500 | 1
335-
AAAAxx | 2500 | 2
336-
HHHHxx | 2500 | 2
337-
OOOOxx | 2500 | 2
338-
VVVVxx | 2500 | 2
339-
AAAAxx | 2500 | 3
340-
HHHHxx | 2500 | 3
341-
OOOOxx | 2500 | 3
342-
VVVVxx | 2500 | 3
343-
(12 rows)
344-
345-
reset enable_material;
346303
-- gather merge test with 0 worker
347304
set max_parallel_workers = 0;
348305
explain (costs off)

src/test/regress/sql/select_parallel.sql

-16
Original file line numberDiff line numberDiff line change
@@ -118,22 +118,6 @@ explain (costs off)
118118

119119
select count(*) from tenk1 group by twenty;
120120

121-
--test rescan behavior of gather merge
122-
set enable_material = false;
123-
124-
explain (costs off)
125-
select * from
126-
(select string4, count(unique2)
127-
from tenk1 group by string4 order by string4) ss
128-
right join (values (1),(2),(3)) v(x) on true;
129-
130-
select * from
131-
(select string4, count(unique2)
132-
from tenk1 group by string4 order by string4) ss
133-
right join (values (1),(2),(3)) v(x) on true;
134-
135-
reset enable_material;
136-
137121
-- gather merge test with 0 worker
138122
set max_parallel_workers = 0;
139123
explain (costs off)

0 commit comments

Comments
 (0)