Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit a22652e

Browse files
committed
Fix race in 032_relfilenode_reuse.pl.
Add wait_for_catchup() call to the test added by commit e2f65f4. Per slow build farm animal grison. Also fix a comment. Discussion: https://postgr.es/m/CA%2BhUKGLJ2Vy8hVQmnYotmTaEKZK0%3D-GcXgNAgcHzArZvtS4L_g%40mail.gmail.com
1 parent ad76c97 commit a22652e

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

src/test/recovery/t/032_relfilenode_reuse.pl

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,8 @@
7272
CREATE TABLE replace_sb(data text);
7373
INSERT INTO replace_sb(data) SELECT random()::text FROM generate_series(1, 15000);]);
7474

75+
$node_primary->wait_for_catchup($node_standby);
76+
7577
# Use longrunning transactions, so that AtEOXact_SMgr doesn't close files
7678
send_query_and_wait(
7779
\%psql_primary,
@@ -101,9 +103,9 @@
101103
# value so we can check everything is OK
102104
$node_primary->safe_psql('conflict_db', "UPDATE large SET datab = 2;");
103105

104-
# Again cause a lot of IO. That'll again write back dirty data, but uses (XXX
105-
# adjust after bugfix) the already opened file descriptor.
106-
# FIXME
106+
# Again cause a lot of IO. That'll again write back dirty data, but uses newly
107+
# opened file descriptors, so we don't confuse old files with new files despite
108+
# recycling relfilenodes.
107109
cause_eviction(\%psql_primary, \%psql_standby);
108110

109111
verify($node_primary, $node_standby, 2,

0 commit comments

Comments
 (0)