Fix bogus error check in pg_execute, per report from lbayuk@mindspring.com.

tglsfdc · tglsfdc · commit a616cbc5e363 · 2002-03-04T02:41:49.000Z
diff --git a/src/interfaces/libpgtcl/pgtclCmds.c b/src/interfaces/libpgtcl/pgtclCmds.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/interfaces/libpgtcl/Attic/pgtclCmds.c,v 1.60 2001/12/03 14:49:46 tgl Exp $
+ *	  $Header: /cvsroot/pgsql/src/interfaces/libpgtcl/Attic/pgtclCmds.c,v 1.61 2002/03/04 02:41:49 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -909,7 +909,7 @@ Pg_execute(ClientData cData, Tcl_Interp *interp, int argc, char *argv[])
 
 		sprintf(oid_buf, "%u", PQoidValue(result));
 		if (Tcl_SetVar(interp, oid_varname, oid_buf,
-					   TCL_LEAVE_ERR_MSG) != TCL_OK)
+					   TCL_LEAVE_ERR_MSG) == NULL)
 		{
 			PQclear(result);
 			return TCL_ERROR;

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $Header: /cvsroot/pgsql/src/interfaces/libpgtcl/Attic/pgtclCmds.c,v 1.60 2001/12/03 14:49:46 tgl Exp $`
	`11`	`+ * $Header: /cvsroot/pgsql/src/interfaces/libpgtcl/Attic/pgtclCmds.c,v 1.61 2002/03/04 02:41:49 tgl Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -909,7 +909,7 @@ Pg_execute(ClientData cData, Tcl_Interp interp, int argc, char argv[])`
`909`	`909`
`910`	`910`	`sprintf(oid_buf, "%u", PQoidValue(result));`
`911`	`911`	`if (Tcl_SetVar(interp, oid_varname, oid_buf,`
`912`		`- TCL_LEAVE_ERR_MSG) != TCL_OK)`
	`912`	`+ TCL_LEAVE_ERR_MSG) == NULL)`
`913`	`913`	`{`
`914`	`914`	`PQclear(result);`
`915`	`915`	`return TCL_ERROR;`