Fix a lo_manage()'s bug.

Hiroshi Inoue · Hiroshi Inoue · commit aa82ac8ab265 · 2001-12-07T04:18:31.000Z
diff --git a/contrib/lo/lo.c b/contrib/lo/lo.c
@@ -1,7 +1,7 @@
 /*
  *	PostgreSQL type definitions for managed LargeObjects.
  *
- *	$Header: /cvsroot/pgsql/contrib/lo/lo.c,v 1.10 2001/10/28 06:25:40 momjian Exp $
+ *	$Header: /cvsroot/pgsql/contrib/lo/lo.c,v 1.11 2001/12/07 04:18:31 inoue Exp $
  *
  */
 
@@ -176,7 +176,7 @@ lo_manage(PG_FUNCTION_ARGS)
 		char	   *orig = SPI_getvalue(trigtuple, tupdesc, attnum);
 		char	   *newv = SPI_getvalue(newtuple, tupdesc, attnum);
 
-		if ((orig != newv && (orig == NULL || newv == NULL)) || (orig != NULL && newv != NULL && strcmp(orig, newv)))
+		if (orig != NULL && (newv == NULL || strcmp(orig, newv)))
 			DirectFunctionCall1(lo_unlink,
 								ObjectIdGetDatum(atooid(orig)));
 

Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`/*`
`2`	`2`	`* PostgreSQL type definitions for managed LargeObjects.`
`3`	`3`	`*`
`4`		`- * $Header: /cvsroot/pgsql/contrib/lo/lo.c,v 1.10 2001/10/28 06:25:40 momjian Exp $`
	`4`	`+ * $Header: /cvsroot/pgsql/contrib/lo/lo.c,v 1.11 2001/12/07 04:18:31 inoue Exp $`
`5`	`5`	`*`
`6`	`6`	`*/`
`7`	`7`
`@@ -176,7 +176,7 @@ lo_manage(PG_FUNCTION_ARGS)`
`176`	`176`	`char *orig = SPI_getvalue(trigtuple, tupdesc, attnum);`
`177`	`177`	`char *newv = SPI_getvalue(newtuple, tupdesc, attnum);`
`178`	`178`
`179`		`- if ((orig != newv && (orig == NULL \|\| newv == NULL)) \|\| (orig != NULL && newv != NULL && strcmp(orig, newv)))`
	`179`	`+ if (orig != NULL && (newv == NULL \|\| strcmp(orig, newv)))`
`180`	`180`	`DirectFunctionCall1(lo_unlink,`
`181`	`181`	`ObjectIdGetDatum(atooid(orig)));`
`182`	`182`