Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit ac933b0

Browse files
committed
Changes made by Arthur Zakirov in gitlab commit bdcadfe of module shared_ispell. Final fixes to PGPRO-1517
1 parent 4aeffea commit ac933b0

File tree

3 files changed

+15
-8
lines changed

3 files changed

+15
-8
lines changed

contrib/shared_ispell/Makefile

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,4 +21,6 @@ include $(top_builddir)/src/Makefile.global
2121
include $(top_srcdir)/contrib/contrib-global.mk
2222
endif
2323

24-
#installcheck:;
24+
# Disabled because these tests require "shared_preload_libraries=shared_ispell",
25+
# which typical installcheck users do not have (e.g. buildfarm clients).
26+
installcheck: REGRESS=

contrib/shared_ispell/README.md

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,18 +16,23 @@ dictionary, this may save you a lot of resources.
1616

1717
Install
1818
-------
19-
Installing the extension is quite simple, especially if you're on 9.1.
20-
In that case all you need to do is this:
2119

22-
$ make install
20+
Before build and install `shared_ispell` you should ensure following:
21+
22+
* PostgreSQL version is 9.6 or 10.
23+
24+
Installing the extension is quite simple. In that case all you need to do is this:
25+
26+
$ git clone git@github.com:postgrespro/shared_ispell.git
27+
$ cd shared_ispell
28+
$ make USE_PGXS=1
29+
$ make USE_PGXS=1 install
2330

2431
and then (after connecting to the database)
2532

2633
db=# CREATE EXTENSION shared_ispell;
2734

28-
If you're on pre-9.1 version, you'll have to do the second part manually
29-
by running the SQL script (shared_ispell--x.y.sql) in the database. If
30-
needed, replace MODULE_PATHNAME by $libdir.
35+
> **Important:** Don't forget to set the `PG_CONFIG` variable in case you want to test `shared_ispell` on a custom build of PostgreSQL. Read more [here](https://wiki.postgresql.org/wiki/Building_and_Installing_PostgreSQL_Extension_Modules).
3136
3237

3338
Config

contrib/shared_ispell/src/shared_ispell.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -413,7 +413,7 @@ init_shared_dict(DictInfo *info, char *dictFile, char *affFile, char *stopFile)
413413
info->lookup = GetCurrentTimestamp();
414414

415415
memcpy(info->dictFile, dictFile, strlen(dictFile) + 1);
416-
memcpy(info->affixFile, dictFile, strlen(affFile)+ 1);
416+
memcpy(info->affixFile, affFile, strlen(affFile) + 1);
417417
if (stopFile != NULL)
418418
memcpy(info->stopFile, stopFile, strlen(stopFile) + 1);
419419
else

0 commit comments

Comments
 (0)