Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit adbd00f

Browse files
committed
Use Test::Builder::todo_start(), replacing $::TODO.
Some pre-2017 Test::More versions need perfect $Test::Builder::Level maintenance to find the variable. Buildfarm member snapper reported an overall failure that the file intended to hide via the TODO construct. That trouble was reachable in v11 and v10. For later branches, this serves as defense in depth. Back-patch to v10 (all supported versions). Discussion: https://postgr.es/m/20220202055556.GB2745933@rfd.leadboat.com
1 parent 0147fc7 commit adbd00f

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

contrib/amcheck/t/003_cic_2pc.pl

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,8 @@
1111

1212
use Test::More tests => 5;
1313

14-
local $TODO = 'filesystem bug' if PostgreSQL::Test::Utils::has_wal_read_bug;
14+
Test::More->builder->todo_start('filesystem bug')
15+
if PostgreSQL::Test::Utils::has_wal_read_bug;
1516

1617
my ($node, $result);
1718

src/test/recovery/t/027_stream_regress.pl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@
88

99
if (PostgreSQL::Test::Utils::has_wal_read_bug)
1010
{
11-
# We'd prefer to use "local $TODO", but the bug causes this test file to
12-
# die(), not merely to fail.
11+
# We'd prefer to use Test::More->builder->todo_start, but the bug causes
12+
# this test file to die(), not merely to fail.
1313
plan skip_all => 'filesystem bug';
1414
}
1515
else

0 commit comments

Comments
 (0)