Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit ae55d9f

Browse files
committed
Remove prepared transactions from main isolation test schedule.
There is no point in running this test when prepared transactions are disabled, which is the default. New make targets that include the test are provided. This will save some useless waste of cycles on buildfarm machines. Backpatch to 9.1 where these tests were introduced.
1 parent 8ca03aa commit ae55d9f

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed

src/test/isolation/Makefile

+10
Original file line numberDiff line numberDiff line change
@@ -72,3 +72,13 @@ installcheck: all
7272

7373
check: all
7474
./pg_isolation_regress --temp-install=./tmp_check --inputdir=$(srcdir) --top-builddir=$(top_builddir) --schedule=$(srcdir)/isolation_schedule
75+
76+
# Versions of the check tests that include the prepared_transactions test
77+
# It only makes sense to run these if set up to use prepared transactions,
78+
# via TEMP_CONFIG for the check case, or via the postgresql.conf for the
79+
# installcheck case.
80+
installcheck-prepared-txns: all
81+
./pg_isolation_regress --psqldir='$(PSQLDIR)' --inputdir=$(srcdir) --schedule=$(srcdir)/isolation_schedule prepared-transactions
82+
83+
check-prepared-txns: all
84+
./pg_isolation_regress --temp-install=./tmp_check --inputdir=$(srcdir) --top-builddir=$(top_builddir) --schedule=$(srcdir)/isolation_schedule prepared-transactions

src/test/isolation/isolation_schedule

-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ test: ri-trigger
99
test: partial-index
1010
test: two-ids
1111
test: multiple-row-versions
12-
test: prepared-transactions
1312
test: fk-contention
1413
test: fk-deadlock
1514
test: fk-deadlock2

0 commit comments

Comments
 (0)