Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit b21aed3

Browse files
committed
Acquire appropriate locks when rewriting during RMV.
Since the query has not been freshly parsed when executing REFRESH MATERIALIZED VIEW, locks must be explicitly taken before rewrite. Backpatch to 9.3. Andres Freund
1 parent b2cd72c commit b21aed3

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

src/backend/commands/matview.c

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -242,9 +242,12 @@ refresh_matview_datafill(DestReceiver *dest, Query *query,
242242
List *rewritten;
243243
PlannedStmt *plan;
244244
QueryDesc *queryDesc;
245+
Query *copied_query;
245246

246-
/* Rewrite, copying the given Query to make sure it's not changed */
247-
rewritten = QueryRewrite((Query *) copyObject(query));
247+
/* Lock and rewrite, using a copy to preserve the original query. */
248+
copied_query = copyObject(query);
249+
AcquireRewriteLocks(copied_query, false);
250+
rewritten = QueryRewrite(copied_query);
248251

249252
/* SELECT should never rewrite to more or less than one SELECT query */
250253
if (list_length(rewritten) != 1)

0 commit comments

Comments
 (0)