Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit b2d867f

Browse files
committed
Some points for portability improvements:
1. C++ style comments in C source for ecpg ( // comment ) 2. compiler finds wrong include file extern.h in ecpg/lib/descriptor.c from include path instead of workdir (rename it ?) 3. fe-connect getsockopt takes a socklen_t as fifth arg not int (use SOCKET_SIZE_TYPE instead) 4. char vs unsigned char in psql calls to libpq 5. empty define that results in an empty but terminated line ( ; ) Now for all but point 3 I can supply changes to the compiler flags, to make the compiler less pedantic. Or is someone interested in the complications ? in the meantime can someone apply the attached patch ? Andreas
1 parent 90cb4c8 commit b2d867f

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

src/interfaces/libpq/fe-connect.c

+2-2
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
*
99
*
1010
* IDENTIFICATION
11-
* $Header: /cvsroot/pgsql/src/interfaces/libpq/fe-connect.c,v 1.123 2000/03/11 03:08:36 tgl Exp $
11+
* $Header: /cvsroot/pgsql/src/interfaces/libpq/fe-connect.c,v 1.124 2000/03/23 17:27:29 momjian Exp $
1212
*
1313
*-------------------------------------------------------------------------
1414
*/
@@ -1080,7 +1080,7 @@ PQconnectPoll(PGconn *conn)
10801080
#else
10811081
char optval;
10821082
#endif
1083-
int optlen = sizeof(optval);
1083+
SOCKET_SIZE_TYPE optlen = sizeof(optval);
10841084

10851085
/* Write ready, since we've made it here, so the connection
10861086
* has been made. */

src/template/aix_42

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
AROPT:crs
2-
CFLAGS:-qchars=signed -qmaxmem=8192 -qhalt=w -qsrcmsg -qcheck=divzero -qlonglong
2+
CFLAGS:-O2 -qmaxmem=16384 -qhalt=w -qsrcmsg -qlanglvl=extended -qlonglong -qcpluscmt
33
SHARED_LIB:-lc
44
ALL:
55
SRCH_INC:

src/test/regress/resultmap

+2
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@ int4/powerpc-unknown-linux-gnu=int4-not-representable
1515
int2/.*-qnx4=int2-too-large
1616
int4/.*-qnx4=int4-too-large
1717
int8/.*-qnx4=int8-exp-three-digits
18+
int2/.*-aix4=int2-too-large
19+
int4/.*-aix4=int4-too-large
1820
float8/alpha-dec-osf=float8-fp-exception
1921
float4/.*-qnx4=float4-exp-three-digits
2022
float8/.*-qnx4=float8-exp-three-digits

0 commit comments

Comments
 (0)