Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit b7cea58

Browse files
committed
amcheck: In verify_heapam, allows tuples with xmin 0.
Commit e88754a caused that case to be reported as corruption, but Peter Geoghegan pointed out that it can legitimately happen in the case of a speculative insertion that aborts, so we'd better not flag it as corruption after all. Back-patch to v14, like the commit that introduced the issue. Discussion: http://postgr.es/m/CAH2-WzmEabzcPTxSY-NXKH6Qt3FkAPYHGQSe2PtvGgj17ZQkCw@mail.gmail.com
1 parent bade01c commit b7cea58

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

contrib/amcheck/verify_heapam.c

+1-2
Original file line numberDiff line numberDiff line change
@@ -1032,8 +1032,7 @@ check_tuple_visibility(HeapCheckContext *ctx, bool *xmin_commit_status_ok,
10321032
switch (get_xid_status(xmin, ctx, &xmin_status))
10331033
{
10341034
case XID_INVALID:
1035-
report_corruption(ctx,
1036-
pstrdup("xmin is invalid"));
1035+
/* Could be the result of a speculative insertion that aborted. */
10371036
return false;
10381037
case XID_BOUNDS_OK:
10391038
*xmin_commit_status_ok = true;

0 commit comments

Comments
 (0)