Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit be98a55

Browse files
committed
Update comment in set_dummy_rel_pathlist().
This comment claimed that set_dummy_rel_pathlist() has callers other than (possibly indirectly) set_rel_size(). It doesn't, so revise the argument to not rely on that. Noted by Richard Guo. Discussion: https://postgr.es/m/CAMbWs4-KFEU_fDuJPNCOkUu3rwvZvKBEytkd9VrM4kH4-2h1CQ@mail.gmail.com
1 parent 213c959 commit be98a55

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/backend/optimizer/path/allpaths.c

+3-3
Original file line numberDiff line numberDiff line change
@@ -2180,9 +2180,9 @@ set_dummy_rel_pathlist(RelOptInfo *rel)
21802180

21812181
/*
21822182
* We set the cheapest-path fields immediately, just in case they were
2183-
* pointing at some discarded path. This is redundant when we're called
2184-
* from set_rel_size(), but not when called from elsewhere, and doing it
2185-
* twice is harmless anyway.
2183+
* pointing at some discarded path. This is redundant in current usage
2184+
* because set_rel_pathlist will do it later, but it's cheap so we keep it
2185+
* for safety and consistency with mark_dummy_rel.
21862186
*/
21872187
set_cheapest(rel);
21882188
}

0 commit comments

Comments
 (0)