Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit bfe2e84

Browse files
committed
Remove -Wl,-undefined,dynamic_lookup in macOS build.
We don't need this anymore, and it prevents build-time error checking that's usually good to have, so remove it. Undoes one change of commit cac7658. Unfortunately, it's much harder to get a similar effect on other common platforms, because we don't want the linker to throw errors for symbols that will be resolved in the core backend. Only macOS and AIX expect the core backend executable to be available while linking loadable modules, so only these platforms can usefully throw errors for unresolved symbols at link time. Discussion: <2652.1475512158@sss.pgh.pa.us>
1 parent 11c0e74 commit bfe2e84

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/Makefile.shlib

+1-1
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ ifeq ($(PORTNAME), darwin)
127127
else
128128
# loadable module
129129
DLSUFFIX = .so
130-
LINK.shared = $(COMPILER) -bundle -multiply_defined suppress -Wl,-undefined,dynamic_lookup
130+
LINK.shared = $(COMPILER) -bundle -multiply_defined suppress
131131
endif
132132
BUILD.exports = $(AWK) '/^[^\#]/ {printf "_%s\n",$$1}' $< >$@
133133
exports_file = $(SHLIB_EXPORTS:%.txt=%.list)

0 commit comments

Comments
 (0)