Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit c7cc9b7

Browse files
committed
Correct pg_recvlogical server version test.
The predecessor test boiled down to "PQserverVersion(NULL) >= 100000", which is always false. No release includes that, so it could not have reintroduced CVE-2018-1058. Back-patch to 9.4, like the addition of the predecessor in commit 8d2814f. Discussion: https://postgr.es/m/20180422215551.GB2676194@rfd.leadboat.com
1 parent 1222db9 commit c7cc9b7

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/bin/pg_basebackup/streamutil.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,7 @@ GetConnection(void)
212212
* 10, so the search path cannot be changed (by us or attackers) on
213213
* earlier versions.
214214
*/
215-
if (dbname != NULL && PQserverVersion(conn) >= 100000)
215+
if (dbname != NULL && PQserverVersion(tmpconn) >= 100000)
216216
{
217217
PGresult *res;
218218

0 commit comments

Comments
 (0)