Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit c7dc56b

Browse files
committed
doc: Fix some grammar for logical decoding description and functions
This documentation is has been added for the support of logical decoding on standbys. Some markups were missing, hence add some where required. Author: Thom Brown Reviewed-by: Justin Pryzby, Daniel Gustafsson Discussion: https://postgr.es/m/CAA-aLv7xCZ0nBJa-NWe0rxBB28TjFjS2JtjiZMoQ+0wsugG+hQ@mail.gmail.com
1 parent 558c9d7 commit c7dc56b

File tree

3 files changed

+15
-13
lines changed

3 files changed

+15
-13
lines changed

doc/src/sgml/func.sgml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27084,8 +27084,8 @@ postgres=# SELECT '0/0'::pg_lsn + pd.segment_number * ps.setting::int + :offset
2708427084
</para>
2708527085
<para>
2708627086
Take a snapshot of running transactions and write it to WAL, without
27087-
having to wait bgwriter or checkpointer to log one. This is useful for
27088-
logical decoding on standby, as logical slot creation has to wait
27087+
having to wait for bgwriter or checkpointer to log one. This is useful
27088+
for logical decoding on standby, as logical slot creation has to wait
2708927089
until such a record is replayed on the standby.
2709027090
</para></entry>
2709127091
</row>

doc/src/sgml/logicaldecoding.sgml

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -321,16 +321,18 @@ postgres=# select * from pg_logical_slot_get_changes('regression_slot', NULL, NU
321321
<command>VACUUM</command> from removing required rows from the system
322322
catalogs, <varname>hot_standby_feedback</varname> should be set on the
323323
standby. In spite of that, if any required rows get removed, the slot gets
324-
invalidated. It's highly recommended to use a physical slot between the primary
325-
and the standby. Otherwise, hot_standby_feedback will work, but only while the
326-
connection is alive (for example a node restart would break it). Then, the
327-
primary may delete system catalog rows that could be needed by the logical
328-
decoding on the standby (as it does not know about the catalog_xmin on the
329-
standby). Existing logical slots on standby also get invalidated if wal_level
330-
on primary is reduced to less than 'logical'. This is done as soon as the
331-
standby detects such a change in the WAL stream. It means, that for walsenders
332-
that are lagging (if any), some WAL records up to the wal_level parameter change
333-
on the primary won't be decoded.
324+
invalidated. It's highly recommended to use a physical slot between the
325+
primary and the standby. Otherwise, <varname>hot_standby_feedback</varname>
326+
will work but only while the connection is alive (for example a node
327+
restart would break it). Then, the primary may delete system catalog rows
328+
that could be needed by the logical decoding on the standby (as it does
329+
not know about the catalog_xmin on the standby). Existing logical slots
330+
on standby also get invalidated if <varname>wal_level</varname> on the
331+
primary is reduced to less than <literal>logical</literal>.
332+
This is done as soon as the standby detects such a change in the WAL stream.
333+
It means that, for walsenders which are lagging (if any), some WAL records up
334+
to the <varname>wal_level</varname> parameter change on the primary won't be
335+
decoded.
334336
</para>
335337

336338
<para>

doc/src/sgml/monitoring.sgml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4757,7 +4757,7 @@ SELECT pid, wait_event_type, wait_event FROM pg_stat_activity WHERE wait_event i
47574757
</para>
47584758
<para>
47594759
Number of uses of logical slots in this database that have been
4760-
canceled due to old snapshots or a too low <xref linkend="guc-wal-level"/>
4760+
canceled due to old snapshots or too low a <xref linkend="guc-wal-level"/>
47614761
on the primary
47624762
</para></entry>
47634763
</row>

0 commit comments

Comments
 (0)