Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit cb2e7dd

Browse files
committed
Prevent pgstats from getting confused when relkind of a relation changes
When the relkind of a relache entry changes, because a table is converted into a view, pgstats can get confused in 15+, leading to crashes or assertion failures. For HEAD, Tom fixed this in b23cd18, by removing support for converting a table to a view, removing the source of the inconsistency. This commit just adds an assertion that a relcache entry's relkind does not change, just in case we end up with another case of that in the future. As there's no cases of changing relkind anymore, we can't add a test that that's handled correctly. For 15, fix the problem by not maintaining the association with the old pgstat entry when the relkind changes during a relcache invalidation processing. In that case the pgstat entry needs to be unlinked first, to avoid PgStat_TableStatus->relation getting out of sync. Also add a test reproducing the issues. No known problem exists in 11-14, so just add the test there. Reported-by: vignesh C <vignesh21@gmail.com> Author: Andres Freund <andres@anarazel.de> Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/CALDaNm2yXz+zOtv7y5zBd5WKT8O0Ld3YxikuU3dcyCvxF7gypA@mail.gmail.com Discussion: https://postgr.es/m/CALDaNm3oZA-8Wbps2Jd1g5_Gjrr-x3YWrJPek-mF5Asrrvz2Dg@mail.gmail.com Backpatch: 15-
1 parent 7ac0f8d commit cb2e7dd

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

src/backend/utils/cache/relcache.c

+7
Original file line numberDiff line numberDiff line change
@@ -2661,6 +2661,13 @@ RelationClearRelation(Relation relation, bool rebuild)
26612661
elog(ERROR, "relation %u deleted while still in use", save_relid);
26622662
}
26632663

2664+
/*
2665+
* If we were to, again, have cases of the relkind of a relcache entry
2666+
* changing, we would need to ensure that pgstats does not get
2667+
* confused.
2668+
*/
2669+
Assert(relation->rd_rel->relkind == newrel->rd_rel->relkind);
2670+
26642671
keep_tupdesc = equalTupleDescs(relation->rd_att, newrel->rd_att);
26652672
keep_rules = equalRuleLocks(relation->rd_rules, newrel->rd_rules);
26662673
keep_policies = equalRSDesc(relation->rd_rsdesc, newrel->rd_rsdesc);

0 commit comments

Comments
 (0)