Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit cd7cdc5

Browse files
Fix incorrect comment about nbtree WAL record.
The nbtree VACUUM WAL record stores its page offset number payload in blk 0 (just like the closely related nbtree DELETE WAL record). Commit ebd551f fixed a similar issue with the DELETE WAL record, but missed this one.
1 parent d48ac00 commit cd7cdc5

File tree

1 file changed

+9
-5
lines changed

1 file changed

+9
-5
lines changed

src/include/access/nbtxlog.h

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -201,7 +201,7 @@ typedef struct xl_btree_reuse_page
201201
* when btinsert() is called.
202202
*
203203
* The records are very similar. The only difference is that xl_btree_delete
204-
* has a snapshotConflictHorizon field to generate recovery conflicts.
204+
* have snapshotConflictHorizon/isCatalogRel fields for recovery conflicts.
205205
* (VACUUM operations can just rely on earlier conflicts generated during
206206
* pruning of the table whose TIDs the to-be-deleted index tuples point to.
207207
* There are also small differences between each REDO routine that we don't go
@@ -225,9 +225,13 @@ typedef struct xl_btree_vacuum
225225
uint16 ndeleted;
226226
uint16 nupdated;
227227

228-
/* DELETED TARGET OFFSET NUMBERS FOLLOW */
229-
/* UPDATED TARGET OFFSET NUMBERS FOLLOW */
230-
/* UPDATED TUPLES METADATA (xl_btree_update) ARRAY FOLLOWS */
228+
/*----
229+
* In payload of blk 0 :
230+
* - DELETED TARGET OFFSET NUMBERS
231+
* - UPDATED TARGET OFFSET NUMBERS
232+
* - UPDATED TUPLES METADATA (xl_btree_update) ITEMS
233+
*----
234+
*/
231235
} xl_btree_vacuum;
232236

233237
#define SizeOfBtreeVacuum (offsetof(xl_btree_vacuum, nupdated) + sizeof(uint16))
@@ -244,7 +248,7 @@ typedef struct xl_btree_delete
244248
* In payload of blk 0 :
245249
* - DELETED TARGET OFFSET NUMBERS
246250
* - UPDATED TARGET OFFSET NUMBERS
247-
* - UPDATED TUPLES METADATA (xl_btree_update) ARRAY
251+
* - UPDATED TUPLES METADATA (xl_btree_update) ITEMS
248252
*----
249253
*/
250254
} xl_btree_delete;

0 commit comments

Comments
 (0)