Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit d03bca4

Browse files
committed
Repair two portability oversights of new test
First, as pointed out by Tom Lane and Michael Paquier, I failed to realize that Windows' PostgresNode needs an extra pg_hba.conf line (added by PostgresNode->set_replication_conf, called internally by ->init() when 'allows_streaming=>1' is given -- but I purposefully omitted that). I think a good fix should be to have nodes with only 'has_archiving=>1' set up for replication too, but that's a bigger discussion. Fix it by calling ->set_replication_conf, which is not unprecedented, as pointed out by Andrew Dunstan. I also forgot to uncomment a ->finish() call for a pumpable IPC::Run file descriptor. Apparently this is innocuous in almost all platforms. Backpatch to 14. The older branches were added this file too, but not this particular part of the test. Discussion: https://postgr.es/m/3000074.1632947632@sss.pgh.pa.us Discussion: https://postgr.es/m/YVT7qwhR8JmC2kfz@paquier.xyz
1 parent 14d755b commit d03bca4

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

src/test/recovery/t/026_overwrite_contrecord.pl

+2-1
Original file line numberDiff line numberDiff line change
@@ -101,6 +101,7 @@
101101
$node->init(
102102
has_archiving => 1,
103103
extra => ['--wal-segsize=1']);
104+
$node->set_replication_conf;
104105

105106
# Note: consistent use of forward slashes here avoids any escaping problems
106107
# that arise from use of backslashes. That means we need to double-quote all
@@ -181,7 +182,7 @@
181182

182183
# Now crash the node with the transaction open
183184
$node->stop('immediate');
184-
#$h->finish();
185+
$h->finish();
185186
$node->start;
186187
$node->safe_psql('postgres', 'create table witness (a int);');
187188
$node->safe_psql('postgres', 'insert into witness values (42)');

0 commit comments

Comments
 (0)