Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit d16f8c8

Browse files
committed
Mark default_transaction_read_only as GUC_REPORT.
This allows clients to find out the setting at connection time without having to expend a query round trip to do so; which is helpful when trying to identify read/write servers. (One must also look at in_hot_standby, but that's already GUC_REPORT, cf bf8a662.) Modifying libpq to make use of this will come soon, but I felt it cleaner to push the server change separately. Haribabu Kommi, Greg Nancarrow, Vignesh C; reviewed at various times by Laurenz Albe, Takayuki Tsunakawa, Peter Smith. Discussion: https://postgr.es/m/CAF3+xM+8-ztOkaV9gHiJ3wfgENTq97QcjXQt+rbFQ6F7oNzt9A@mail.gmail.com
1 parent 75dbfe4 commit d16f8c8

File tree

3 files changed

+8
-3
lines changed

3 files changed

+8
-3
lines changed

doc/src/sgml/libpq.sgml

+3-1
Original file line numberDiff line numberDiff line change
@@ -2191,6 +2191,7 @@ const char *PQparameterStatus(const PGconn *conn, const char *paramName);
21912191
<varname>server_encoding</varname>,
21922192
<varname>client_encoding</varname>,
21932193
<varname>application_name</varname>,
2194+
<varname>default_transaction_read_only</varname>,
21942195
<varname>in_hot_standby</varname>,
21952196
<varname>is_superuser</varname>,
21962197
<varname>session_authorization</varname>,
@@ -2206,7 +2207,8 @@ const char *PQparameterStatus(const PGconn *conn, const char *paramName);
22062207
<varname>IntervalStyle</varname> was not reported by releases before 8.4;
22072208
<varname>application_name</varname> was not reported by releases before
22082209
9.0;
2209-
<varname>in_hot_standby</varname> was not reported by releases before
2210+
<varname>default_transaction_read_only</varname> and
2211+
<varname>in_hot_standby</varname> were not reported by releases before
22102212
14.)
22112213
Note that
22122214
<varname>server_version</varname>,

doc/src/sgml/protocol.sgml

+3-1
Original file line numberDiff line numberDiff line change
@@ -1278,6 +1278,7 @@ SELCT 1/0;<!-- this typo is intentional -->
12781278
<varname>server_encoding</varname>,
12791279
<varname>client_encoding</varname>,
12801280
<varname>application_name</varname>,
1281+
<varname>default_transaction_read_only</varname>,
12811282
<varname>in_hot_standby</varname>,
12821283
<varname>is_superuser</varname>,
12831284
<varname>session_authorization</varname>,
@@ -1293,7 +1294,8 @@ SELCT 1/0;<!-- this typo is intentional -->
12931294
<varname>IntervalStyle</varname> was not reported by releases before 8.4;
12941295
<varname>application_name</varname> was not reported by releases before
12951296
9.0;
1296-
<varname>in_hot_standby</varname> was not reported by releases before
1297+
<varname>default_transaction_read_only</varname> and
1298+
<varname>in_hot_standby</varname> were not reported by releases before
12971299
14.)
12981300
Note that
12991301
<varname>server_version</varname>,

src/backend/utils/misc/guc.c

+2-1
Original file line numberDiff line numberDiff line change
@@ -1619,7 +1619,8 @@ static struct config_bool ConfigureNamesBool[] =
16191619
{
16201620
{"default_transaction_read_only", PGC_USERSET, CLIENT_CONN_STATEMENT,
16211621
gettext_noop("Sets the default read-only status of new transactions."),
1622-
NULL
1622+
NULL,
1623+
GUC_REPORT
16231624
},
16241625
&DefaultXactReadOnly,
16251626
false,

0 commit comments

Comments
 (0)