Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit d268d0f

Browse files
committed
ecpg: use our instead of my in parse.pl to fix perlcritic complaint
In db0a272 I used open(our $something, ...), which perlcritic doesn't like. It looks like the warning is due to perlcritic knowing about 'my' but not 'our' when checking for bareword file handles. However, it's clearly unnecessary to use "our" here, change it to "my". Via buildfarm member crake and discussion with Tom Lane. Discussion: https://postgr.es/m/20220718215042.sl3hivoupdb7lkwv@awork3.anarazel.de
1 parent eb6569f commit d268d0f

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/interfaces/ecpg/preproc/parse.pl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,8 @@
2727
'parser=s' => \$parser,) or die "wrong arguments";
2828

2929
# open parser / output file early, to raise errors early
30-
open(our $parserfh, '<', $parser) or die "could not open parser file $parser";
31-
open(our $outfh, '>', $outfile) or die "could not open output file $outfile";
30+
open(my $parserfh, '<', $parser) or die "could not open parser file $parser";
31+
open(my $outfh, '>', $outfile) or die "could not open output file $outfile";
3232

3333
my $copymode = 0;
3434
my $brace_indent = 0;

0 commit comments

Comments
 (0)