Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit d3586fc

Browse files
committed
Ensure unlogged tables are reset even if crash recovery errors out.
Unlogged relations are reset at the end of crash recovery as they're only synced to disk during a proper shutdown. Unfortunately that and later steps can fail, e.g. due to running out of space. This reset was, up to now performed after marking the database as having finished crash recovery successfully. As out of space errors trigger a crash restart that could lead to the situation that not all unlogged relations are reset. Once that happend usage of unlogged relations could yield errors like "could not open file "...": No such file or directory". Luckily clusters that show the problem can be fixed by performing a immediate shutdown, and starting the database again. To fix, just call ResetUnloggedRelations(UNLOGGED_RELATION_INIT) earlier, before marking the database as having successfully recovered. Discussion: 20140912112246.GA4984@alap3.anarazel.de Backpatch to 9.1 where unlogged tables were introduced. Abhijit Menon-Sen and Andres Freund
1 parent 0ce627d commit d3586fc

File tree

1 file changed

+10
-8
lines changed
  • src/backend/access/transam

1 file changed

+10
-8
lines changed

src/backend/access/transam/xlog.c

+10-8
Original file line numberDiff line numberDiff line change
@@ -6446,6 +6446,16 @@ StartupXLOG(void)
64466446
*/
64476447
ShutdownWalRcv();
64486448

6449+
/*
6450+
* Reset unlogged relations to the contents of their INIT fork. This is
6451+
* done AFTER recovery is complete so as to include any unlogged relations
6452+
* created during recovery, but BEFORE recovery is marked as having
6453+
* completed successfully. Otherwise we'd not retry if any of the post
6454+
* end-of-recovery steps fail.
6455+
*/
6456+
if (InRecovery)
6457+
ResetUnloggedRelations(UNLOGGED_RELATION_INIT);
6458+
64496459
/*
64506460
* We don't need the latch anymore. It's not strictly necessary to disown
64516461
* it, but let's do it for the sake of tidiness.
@@ -6713,14 +6723,6 @@ StartupXLOG(void)
67136723
*/
67146724
PreallocXlogFiles(EndOfLog);
67156725

6716-
/*
6717-
* Reset initial contents of unlogged relations. This has to be done
6718-
* AFTER recovery is complete so that any unlogged relations created
6719-
* during recovery also get picked up.
6720-
*/
6721-
if (InRecovery)
6722-
ResetUnloggedRelations(UNLOGGED_RELATION_INIT);
6723-
67246726
/*
67256727
* Okay, we're officially UP.
67266728
*/

0 commit comments

Comments
 (0)