Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit d4b090f

Browse files
committed
Revert "Insert temporary debugging output in regression tests."
This reverts commit f03a9ca, in the v12 branch only. We don't want to ship v12 with that, since it causes occasional test failures (as a result of statistics transmission not being entirely reliable). I'll leave it in HEAD though, in hopes that we'll eventually capture an instance of the original problematic behavior.
1 parent 9e1c9f9 commit d4b090f

File tree

4 files changed

+0
-70
lines changed

4 files changed

+0
-70
lines changed

src/test/regress/expected/select_parallel.out

Lines changed: 0 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -89,33 +89,6 @@ select round(avg(aa)), sum(aa) from a_star a3;
8989
14 | 355
9090
(1 row)
9191

92-
-- Temporary hack to investigate whether extra vacuum/analyze is happening
93-
select relname, relpages, reltuples
94-
from pg_class
95-
where relname like '__star' order by relname;
96-
relname | relpages | reltuples
97-
---------+----------+-----------
98-
a_star | 1 | 3
99-
b_star | 1 | 4
100-
c_star | 1 | 4
101-
d_star | 1 | 16
102-
e_star | 1 | 7
103-
f_star | 1 | 16
104-
(6 rows)
105-
106-
select relname, vacuum_count, analyze_count, autovacuum_count, autoanalyze_count
107-
from pg_stat_all_tables
108-
where relname like '__star' order by relname;
109-
relname | vacuum_count | analyze_count | autovacuum_count | autoanalyze_count
110-
---------+--------------+---------------+------------------+-------------------
111-
a_star | 1 | 0 | 0 | 0
112-
b_star | 1 | 0 | 0 | 0
113-
c_star | 1 | 0 | 0 | 0
114-
d_star | 1 | 0 | 0 | 0
115-
e_star | 1 | 0 | 0 | 0
116-
f_star | 1 | 0 | 0 | 0
117-
(6 rows)
118-
11992
-- Disable Parallel Append
12093
alter table a_star reset (parallel_workers);
12194
alter table b_star reset (parallel_workers);

src/test/regress/expected/stats.out

Lines changed: 0 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -199,33 +199,6 @@ FROM prevstats AS pr;
199199
t
200200
(1 row)
201201

202-
-- Temporary hack to investigate whether extra vacuum/analyze is happening
203-
select relname, relpages, reltuples
204-
from pg_class
205-
where relname like '__star' order by relname;
206-
relname | relpages | reltuples
207-
---------+----------+-----------
208-
a_star | 1 | 3
209-
b_star | 1 | 4
210-
c_star | 1 | 4
211-
d_star | 1 | 16
212-
e_star | 1 | 7
213-
f_star | 1 | 16
214-
(6 rows)
215-
216-
select relname, vacuum_count, analyze_count, autovacuum_count, autoanalyze_count
217-
from pg_stat_all_tables
218-
where relname like '__star' order by relname;
219-
relname | vacuum_count | analyze_count | autovacuum_count | autoanalyze_count
220-
---------+--------------+---------------+------------------+-------------------
221-
a_star | 1 | 0 | 0 | 0
222-
b_star | 1 | 0 | 0 | 0
223-
c_star | 1 | 0 | 0 | 0
224-
d_star | 1 | 0 | 0 | 0
225-
e_star | 1 | 0 | 0 | 0
226-
f_star | 1 | 0 | 0 | 0
227-
(6 rows)
228-
229202
DROP TABLE trunc_stats_test, trunc_stats_test1, trunc_stats_test2, trunc_stats_test3, trunc_stats_test4;
230203
DROP TABLE prevstats;
231204
-- End of Stats Test

src/test/regress/sql/select_parallel.sql

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -36,14 +36,6 @@ explain (costs off)
3636
select round(avg(aa)), sum(aa) from a_star;
3737
select round(avg(aa)), sum(aa) from a_star a3;
3838

39-
-- Temporary hack to investigate whether extra vacuum/analyze is happening
40-
select relname, relpages, reltuples
41-
from pg_class
42-
where relname like '__star' order by relname;
43-
select relname, vacuum_count, analyze_count, autovacuum_count, autoanalyze_count
44-
from pg_stat_all_tables
45-
where relname like '__star' order by relname;
46-
4739
-- Disable Parallel Append
4840
alter table a_star reset (parallel_workers);
4941
alter table b_star reset (parallel_workers);

src/test/regress/sql/stats.sql

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -174,14 +174,6 @@ SELECT st.heap_blks_read + st.heap_blks_hit >= pr.heap_blks + cl.relpages,
174174
SELECT pr.snap_ts < pg_stat_get_snapshot_timestamp() as snapshot_newer
175175
FROM prevstats AS pr;
176176

177-
-- Temporary hack to investigate whether extra vacuum/analyze is happening
178-
select relname, relpages, reltuples
179-
from pg_class
180-
where relname like '__star' order by relname;
181-
select relname, vacuum_count, analyze_count, autovacuum_count, autoanalyze_count
182-
from pg_stat_all_tables
183-
where relname like '__star' order by relname;
184-
185177
DROP TABLE trunc_stats_test, trunc_stats_test1, trunc_stats_test2, trunc_stats_test3, trunc_stats_test4;
186178
DROP TABLE prevstats;
187179
-- End of Stats Test

0 commit comments

Comments
 (0)