Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit d547f7c

Browse files
author
Amit Kapila
committed
Re-order disable_on_error in tab-complete.
By convention, the tab-complete subscription parameters are listed in the COMPLETE_WITH lists in alphabetical order, but when the "disable_on_error" parameter was introduced this was not done. This patch just tidies that up. Reported-by: Peter Smith Author: Peter Smith Reviewed-by: Euler Taveira, Takamichi Osumi Backpatch-through: 15, where it was introduced Discussion: https://postgr.es/m/CAHut+PucvKZgg_eJzUW--iL6DXHg1Jwj6F09tQziE3kUF67uLg@mail.gmail.com
1 parent 1409ead commit d547f7c

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/bin/psql/tab-complete.c

+3-3
Original file line numberDiff line numberDiff line change
@@ -1873,7 +1873,7 @@ psql_completion(const char *text, int start, int end)
18731873
COMPLETE_WITH("(", "PUBLICATION");
18741874
/* ALTER SUBSCRIPTION <name> SET ( */
18751875
else if (HeadMatches("ALTER", "SUBSCRIPTION", MatchAny) && TailMatches("SET", "("))
1876-
COMPLETE_WITH("binary", "slot_name", "streaming", "synchronous_commit", "disable_on_error");
1876+
COMPLETE_WITH("binary", "disable_on_error", "slot_name", "streaming", "synchronous_commit");
18771877
/* ALTER SUBSCRIPTION <name> SKIP ( */
18781878
else if (HeadMatches("ALTER", "SUBSCRIPTION", MatchAny) && TailMatches("SKIP", "("))
18791879
COMPLETE_WITH("lsn");
@@ -3152,8 +3152,8 @@ psql_completion(const char *text, int start, int end)
31523152
/* Complete "CREATE SUBSCRIPTION <name> ... WITH ( <opt>" */
31533153
else if (HeadMatches("CREATE", "SUBSCRIPTION") && TailMatches("WITH", "("))
31543154
COMPLETE_WITH("binary", "connect", "copy_data", "create_slot",
3155-
"enabled", "slot_name", "streaming",
3156-
"synchronous_commit", "two_phase", "disable_on_error");
3155+
"disable_on_error", "enabled", "slot_name", "streaming",
3156+
"synchronous_commit", "two_phase");
31573157

31583158
/* CREATE TRIGGER --- is allowed inside CREATE SCHEMA, so use TailMatches */
31593159

0 commit comments

Comments
 (0)