Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit d79fb5d

Browse files
committed
Add missing NO_INSTALLCHECK in commit_ts and test_rls_hooks
This bypasses installcheck if specified, which makes sense for those modules as they require non-default configuration, something which typical users don't have. Those have been missing from the start, still no back-patch is done. This will be used by an upcoming patch for MSVC scripts adding support for NO_INSTALLCHECK as installcheck is the default mode for contrib and modules for performance reasons in the buildfarm. Author: Michael Paquier Reviewed-by: Andrew Dunstan Discussion: https://postgr.es/m/20181126054302.GI1776@paquier.xyz
1 parent 4c70336 commit d79fb5d

File tree

2 files changed

+6
-0
lines changed

2 files changed

+6
-0
lines changed

src/test/modules/commit_ts/Makefile

+3
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@
22

33
REGRESS = commit_timestamp
44
REGRESS_OPTS = --temp-config=$(top_srcdir)/src/test/modules/commit_ts/commit_ts.conf
5+
# Disabled because these tests require "track_commit_timestamp = on",
6+
# which typical installcheck users do not have (e.g. buildfarm clients).
7+
NO_INSTALLCHECK = 1
58

69
ifdef USE_PGXS
710
PG_CONFIG = pg_config

src/test/modules/test_rls_hooks/Makefile

+3
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,9 @@ EXTENSION = test_rls_hooks
99

1010
REGRESS = test_rls_hooks
1111
REGRESS_OPTS = --temp-config=$(top_srcdir)/src/test/modules/test_rls_hooks/rls_hooks.conf
12+
# Disabled because these tests require "shared_preload_libraries=test_rls_hooks",
13+
# which typical installcheck users do not have (e.g. buildfarm clients).
14+
NO_INSTALLCHECK = 1
1215

1316
ifdef USE_PGXS
1417
PG_CONFIG = pg_config

0 commit comments

Comments
 (0)