Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit db8db62

Browse files
committed
Revert "Switch TAP tests of pg_rewind to use a role with minimal permissions"
This reverts commit d4e2a84, which added a new user with limited permissions to run the TAP tests of pg_rewind. Buildfarm machine members on Windows jacana and bowerbird have been complaining about that, the new role not being able to run the rewind because SSPI is not configured to allow it. Fixing the test requires passing down directly the new user to pg_regress with --create-role so as SSPI can work properly. Reported-by: Andrew Dunstan Discussion: https://postgr.es/m/3cd43d33-f415-cc41-ade3-7230ab15b2c9@2ndQuadrant.com
1 parent 77bd49a commit db8db62

File tree

1 file changed

+0
-17
lines changed

1 file changed

+0
-17
lines changed

src/bin/pg_rewind/t/RewindTest.pm

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -144,20 +144,6 @@ sub start_master
144144
{
145145
$node_master->start;
146146

147-
# Create a custom role which will be used to run pg_rewind. This
148-
# role is used for all the tests, and has minimal permissions enough
149-
# to rewind from an online source.
150-
$node_master->psql('postgres', "
151-
CREATE ROLE rewind_user LOGIN;
152-
GRANT EXECUTE ON function pg_catalog.pg_ls_dir(text, boolean, boolean)
153-
TO rewind_user;
154-
GRANT EXECUTE ON function pg_catalog.pg_stat_file(text, boolean)
155-
TO rewind_user;
156-
GRANT EXECUTE ON function pg_catalog.pg_read_binary_file(text)
157-
TO rewind_user;
158-
GRANT EXECUTE ON function pg_catalog.pg_read_binary_file(text, bigint, bigint, boolean)
159-
TO rewind_user;");
160-
161147
#### Now run the test-specific parts to initialize the master before setting
162148
# up standby
163149

@@ -221,9 +207,6 @@ sub run_pg_rewind
221207
my $standby_connstr = $node_standby->connstr('postgres');
222208
my $tmp_folder = TestLib::tempdir;
223209

224-
# Append the rewind-specific role to the connection string.
225-
$standby_connstr = "$standby_connstr user=rewind_user";
226-
227210
# Stop the master and be ready to perform the rewind
228211
$node_master->stop;
229212

0 commit comments

Comments
 (0)