Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit dbf34c5

Browse files
committed
This problem had nothing to do with the upgrades I made. There
was a 2000 character buffer allocated for results, and the files you refer to produce a 2765 byte column called formsource. This should not have worked with any version of libpgtcl. Nevertheless, the limit is an artificial one, since there is no need to use this intermediate buffer where it is being used and abused. Randy Kunkee <kunkee@pluto.ops.NeoSoft.com>
1 parent 57b5966 commit dbf34c5

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/interfaces/libpgtcl/pgtclCmds.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
*
88
*
99
* IDENTIFICATION
10-
* $Header: /cvsroot/pgsql/src/interfaces/libpgtcl/Attic/pgtclCmds.c,v 1.22 1998/03/15 08:02:58 scrappy Exp $
10+
* $Header: /cvsroot/pgsql/src/interfaces/libpgtcl/Attic/pgtclCmds.c,v 1.23 1998/03/30 17:39:16 momjian Exp $
1111
*
1212
*-------------------------------------------------------------------------
1313
*/
@@ -1226,6 +1226,7 @@ Pg_select(ClientData cData, Tcl_Interp *interp, int argc, char **argv)
12261226
}
12271227

12281228
Tcl_SetVar2(interp, argv[3], ".headers", Tcl_DStringValue(&headers), 0);
1229+
Tcl_DStringFree(&headers);
12291230
sprintf(buffer, "%d", ncols);
12301231
Tcl_SetVar2(interp, argv[3], ".numcols", buffer, 0);
12311232

@@ -1236,8 +1237,7 @@ Pg_select(ClientData cData, Tcl_Interp *interp, int argc, char **argv)
12361237

12371238
for (column = 0; column < ncols; column++)
12381239
{
1239-
strcpy(buffer, PQgetvalue(result, tupno, column));
1240-
Tcl_SetVar2(interp, argv[3], info[column].cname, buffer, 0);
1240+
Tcl_SetVar2(interp, argv[3], info[column].cname, PQgetvalue(result, tupno, column), 0);
12411241
}
12421242

12431243
Tcl_SetVar2(interp, argv[3], ".command", "update", 0);

0 commit comments

Comments
 (0)