Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit dc878ff

Browse files
Remove spurious code comments in standby related code
GetRunningTransactionData() suggested that subxids were not worth optimizing away if overflowed, yet they have already been removed for that case. Changes to LogAccessExclusiveLock() API forgot to remove the prior comment when it was copied to LockAcquire().
1 parent 802bde8 commit dc878ff

File tree

2 files changed

+1
-8
lines changed

2 files changed

+1
-8
lines changed

src/backend/storage/ipc/procarray.c

+1-3
Original file line numberDiff line numberDiff line change
@@ -1926,9 +1926,7 @@ ProcArrayInstallRestoredXmin(TransactionId xmin, PGPROC *proc)
19261926
* that bookkeeping.
19271927
*
19281928
* Note that if any transaction has overflowed its cached subtransactions
1929-
* then there is no real need include any subtransactions. That isn't a
1930-
* common enough case to worry about optimising the size of the WAL record,
1931-
* and we may wish to see that data for diagnostic purposes anyway.
1929+
* then there is no real need include any subtransactions.
19321930
*/
19331931
RunningTransactions
19341932
GetRunningTransactionData(void)

src/backend/storage/ipc/standby.c

-5
Original file line numberDiff line numberDiff line change
@@ -1050,11 +1050,6 @@ LogAccessExclusiveLock(Oid dbOid, Oid relOid)
10501050

10511051
xlrec.xid = GetCurrentTransactionId();
10521052

1053-
/*
1054-
* Decode the locktag back to the original values, to avoid sending lots
1055-
* of empty bytes with every message. See lock.h to check how a locktag
1056-
* is defined for LOCKTAG_RELATION
1057-
*/
10581053
xlrec.dbOid = dbOid;
10591054
xlrec.relOid = relOid;
10601055

0 commit comments

Comments
 (0)