Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit df6b19f

Browse files
committed
Make agreed-on updates in perltidy options.
Our standard version of perltidy is now 20230309. Add a --valign-exclusion-list setting to reduce crosstalk between nearby lines of Perl code. Also, update instructions for running pgindent (missed in b16259b). Discussion: https://postgr.es/m/20230428092545.qfb3y5wcu4cm75ur@alvherre.pgsql
1 parent 722541e commit df6b19f

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

src/tools/pgindent/README

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,16 +14,16 @@ PREREQUISITES:
1414
sibling directory src/tools/pg_bsd_indent; see the directions
1515
in that directory's README file.
1616

17-
2) Install perltidy. Please be sure it is version 20170521 (older and newer
17+
2) Install perltidy. Please be sure it is version 20230309 (older and newer
1818
versions make different formatting choices, and we want consistency).
1919
You can get the correct version from
2020
https://cpan.metacpan.org/authors/id/S/SH/SHANCOCK/
2121
To install, follow the usual install process for a Perl module
2222
("man perlmodinstall" explains it). Or, if you have cpan installed,
2323
this should work:
24-
cpan SHANCOCK/Perl-Tidy-20170521.tar.gz
24+
cpan SHANCOCK/Perl-Tidy-20230309.tar.gz
2525
Or if you have cpanm installed, you can just use:
26-
cpanm https://cpan.metacpan.org/authors/id/S/SH/SHANCOCK/Perl-Tidy-20170521.tar.gz
26+
cpanm https://cpan.metacpan.org/authors/id/S/SH/SHANCOCK/Perl-Tidy-20230309.tar.gz
2727

2828
DOING THE INDENT RUN:
2929

@@ -38,7 +38,7 @@ DOING THE INDENT RUN:
3838

3939
3) Run pgindent on the C files:
4040

41-
src/tools/pgindent/pgindent
41+
src/tools/pgindent/pgindent .
4242

4343
If any files generate errors, restore their original versions with
4444
"git checkout", and see below for cleanup ideas.

src/tools/pgindent/perltidyrc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,3 +14,4 @@
1414
--paren-vertical-tightness=2
1515
--paren-vertical-tightness-closing=2
1616
--noblanks-before-comments
17+
--valign-exclusion-list=", = => =~ |= || && if or qw unless"

0 commit comments

Comments
 (0)