Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit df7c5cb

Browse files
author
Amit Kapila
committed
Fix comments in reorderbuffer.c.
Author: Dave Cramer Reviewed-by: David G. Johnston Discussion: https://postgr.es/m/CADK3HHL8do4Fp1bsymgNasx375njV3AR7zY3UgYwzbL_Dx-n2Q@mail.gmail.com
1 parent b74d449 commit df7c5cb

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

src/backend/replication/logical/reorderbuffer.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@
4747
* ReorderBuffer uses two special memory context types - SlabContext for
4848
* allocations of fixed-length structures (changes and transactions), and
4949
* GenerationContext for the variable-length transaction data (allocated
50-
* and freed in groups with similar lifespan).
50+
* and freed in groups with similar lifespans).
5151
*
5252
* To limit the amount of memory used by decoded changes, we track memory
5353
* used at the reorder buffer level (i.e. total amount of memory), and for
@@ -58,7 +58,7 @@
5858
* Only decoded changes are evicted from memory (spilled to disk), not the
5959
* transaction records. The number of toplevel transactions is limited,
6060
* but a transaction with many subtransactions may still consume significant
61-
* amounts of memory. The transaction records are fairly small, though, and
61+
* amounts of memory. The transaction records are fairly small though and
6262
* are not included in the memory limit.
6363
*
6464
* The current eviction algorithm is very simple - the transaction is
@@ -69,13 +69,13 @@
6969
*
7070
* We still rely on max_changes_in_memory when loading serialized changes
7171
* back into memory. At that point we can't use the memory limit directly
72-
* as we load the subxacts independently. One option do deal with this
72+
* as we load the subxacts independently. One option to deal with this
7373
* would be to count the subxacts, and allow each to allocate 1/N of the
7474
* memory limit. That however does not seem very appealing, because with
75-
* many subtransactions it may easily cause trashing (short cycles of
75+
* many subtransactions it may easily cause thrashing (short cycles of
7676
* deserializing and applying very few changes). We probably should give
7777
* a bit more memory to the oldest subtransactions, because it's likely
78-
* the source for the next sequence of changes.
78+
* they are the source for the next sequence of changes.
7979
*
8080
* -------------------------------------------------------------------------
8181
*/

0 commit comments

Comments
 (0)