Fix dead code

petere · petere · commit dfbb092cff70 · 2024-12-04T16:44:40.000+01:00
from commit 85b7efa per Coverity report
diff --git a/src/backend/utils/adt/like_match.c b/src/backend/utils/adt/like_match.c
@@ -333,13 +333,14 @@ MatchText(const char *t, int tlen, const char *p, int plen, pg_locale_t locale)
 				 * fails.  Otherwise, try again with a longer substring.
 				 */
 				if (t1len == 0)
+				{
+					if (buf)
+						pfree(buf);
 					return LIKE_FALSE;
+				}
 				else
 					NextChar(t1, t1len);
 			}
-			if (buf)
-				pfree(buf);
-			continue;
 		}
 		else if (GETCHAR(*p, locale) != GETCHAR(*t, locale))
 		{

Original file line number	Diff line number	Diff line change
`@@ -333,13 +333,14 @@ MatchText(const char t, int tlen, const char p, int plen, pg_locale_t locale)`
`333`	`333`	`* fails. Otherwise, try again with a longer substring.`
`334`	`334`	`*/`
`335`	`335`	`if (t1len == 0)`
	`336`	`+ {`
	`337`	`+ if (buf)`
	`338`	`+ pfree(buf);`
`336`	`339`	`return LIKE_FALSE;`
	`340`	`+ }`
`337`	`341`	`else`
`338`	`342`	`NextChar(t1, t1len);`
`339`	`343`	`}`
`340`		`- if (buf)`
`341`		`- pfree(buf);`
`342`		`- continue;`
`343`	`344`	`}`
`344`	`345`	`else if (GETCHAR(p, locale) != GETCHAR(t, locale))`
`345`	`346`	`{`