Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit e1a6375

Browse files
committed
Comment fixes.
Jeff Davis, somewhat edited by me
1 parent 152525b commit e1a6375

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

src/backend/commands/tablecmds.c

+4-3
Original file line numberDiff line numberDiff line change
@@ -8784,9 +8784,10 @@ copy_relation_data(SMgrRelation src, SMgrRelation dst,
87848784
pfree(buf);
87858785

87868786
/*
8787-
* If the rel isn't temp, we must fsync it down to disk before it's safe
8788-
* to commit the transaction. (For a temp rel we don't care since the rel
8789-
* will be uninteresting after a crash anyway.)
8787+
* If the rel is WAL-logged, must fsync before commit. We use heap_sync
8788+
* to ensure that the toast table gets fsync'd too. (For a temp or
8789+
* unlogged rel we don't care since the data will be gone after a crash
8790+
* anyway.)
87908791
*
87918792
* It's obvious that we must do this when not WAL-logging the copy. It's
87928793
* less obvious that we have to do it even if we did WAL-log the copied

src/backend/storage/file/reinit.c

-1
Original file line numberDiff line numberDiff line change
@@ -337,7 +337,6 @@ ResetUnloggedRelationsInDbspaceDir(const char *dbspacedirname, int op)
337337
copy_file(srcpath, dstpath);
338338
}
339339

340-
/* Done with the first pass. */
341340
FreeDir(dbspace_dir);
342341
}
343342
}

0 commit comments

Comments
 (0)