Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit e529b2d

Browse files
committed
Ensure HAVE_DECL_XXX macros in MSVC builds match those in Unix.
Autoconf's AC_CHECK_DECLS() always defines HAVE_DECL_whatever as 1 or 0, but some of the entries in msvc/Solution.pm showed such symbols as "undef" instead of 0. Fix that for consistency. There's no live bug in current usages AFAICS, but it's not hard to imagine one creeping in if more-complex #if tests get added. Back-patch to v13, which is as far back as Solution.pm contains this data. The inconsistency still exists in the manually-filled pg_config_ext.h.win32 files of older branches; but as long as the problem is only latent, it doesn't seem worth the trouble to clean things up there. Discussion: https://postgr.es/m/3185430.1626133592@sss.pgh.pa.us
1 parent 0da3c1b commit e529b2d

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

src/tools/msvc/Solution.pm

+5-5
Original file line numberDiff line numberDiff line change
@@ -239,19 +239,19 @@ sub GenerateFiles
239239
HAVE_CRYPTO_LOCK => undef,
240240
HAVE_DECL_FDATASYNC => 0,
241241
HAVE_DECL_F_FULLFSYNC => 0,
242-
HAVE_DECL_LLVMCREATEGDBREGISTRATIONLISTENER => undef,
243-
HAVE_DECL_LLVMCREATEPERFJITEVENTLISTENER => undef,
242+
HAVE_DECL_LLVMCREATEGDBREGISTRATIONLISTENER => 0,
243+
HAVE_DECL_LLVMCREATEPERFJITEVENTLISTENER => 0,
244244
HAVE_DECL_LLVMGETHOSTCPUNAME => 0,
245245
HAVE_DECL_LLVMGETHOSTCPUFEATURES => 0,
246246
HAVE_DECL_LLVMORCGETSYMBOLADDRESSIN => 0,
247-
HAVE_DECL_POSIX_FADVISE => undef,
247+
HAVE_DECL_POSIX_FADVISE => 0,
248248
HAVE_DECL_PREADV => 0,
249249
HAVE_DECL_PWRITEV => 0,
250250
HAVE_DECL_RTLD_GLOBAL => 0,
251251
HAVE_DECL_RTLD_NOW => 0,
252252
HAVE_DECL_SIGWAIT => 0,
253-
HAVE_DECL_STRLCAT => undef,
254-
HAVE_DECL_STRLCPY => undef,
253+
HAVE_DECL_STRLCAT => 0,
254+
HAVE_DECL_STRLCPY => 0,
255255
HAVE_DECL_STRNLEN => 1,
256256
HAVE_DECL_STRTOLL => 1,
257257
HAVE_DECL_STRTOULL => 1,

0 commit comments

Comments
 (0)