Add comment explaining why RelationOpenSmgr() call is not needed.

tglsfdc · tglsfdc · commit e58a94470092 · 2006-01-07T22:30:43.000Z
diff --git a/src/backend/executor/execMain.c b/src/backend/executor/execMain.c
@@ -26,7 +26,7 @@
  *
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/executor/execMain.c,v 1.262 2005/12/02 20:03:40 tgl Exp $
+ *	  $PostgreSQL: pgsql/src/backend/executor/execMain.c,v 1.263 2006/01/07 22:30:43 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -1002,6 +1002,7 @@ ExecEndPlan(PlanState *planstate, EState *estate)
 			!estate->es_into_relation_descriptor->rd_istemp)
 		{
 			FlushRelationBuffers(estate->es_into_relation_descriptor);
+			/* FlushRelationBuffers will have opened rd_smgr */
 			smgrimmedsync(estate->es_into_relation_descriptor->rd_smgr);
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@`
`26`	`26`	`*`
`27`	`27`	`*`
`28`	`28`	`* IDENTIFICATION`
`29`		`- * $PostgreSQL: pgsql/src/backend/executor/execMain.c,v 1.262 2005/12/02 20:03:40 tgl Exp $`
	`29`	`+ * $PostgreSQL: pgsql/src/backend/executor/execMain.c,v 1.263 2006/01/07 22:30:43 tgl Exp $`
`30`	`30`	`*`
`31`	`31`	`*-------------------------------------------------------------------------`
`32`	`32`	`*/`
`@@ -1002,6 +1002,7 @@ ExecEndPlan(PlanState planstate, EState estate)`
`1002`	`1002`	`!estate->es_into_relation_descriptor->rd_istemp)`
`1003`	`1003`	`{`
`1004`	`1004`	`FlushRelationBuffers(estate->es_into_relation_descriptor);`
	`1005`	`+ /* FlushRelationBuffers will have opened rd_smgr */`
`1005`	`1006`	`smgrimmedsync(estate->es_into_relation_descriptor->rd_smgr);`
`1006`	`1007`	`}`
`1007`	`1008`