Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit e7ee433

Browse files
committed
Skip tab-completion tests if envar SKIP_READLINE_TESTS is defined.
Experience so far suggests that getting these tests to pass on all libedit versions that are out there may be impossible, or require dumbing down the tests to the point of uselessness. So we need to provide a way to skip them when the user knows they'll fail. An environment variable is probably the most convenient way to deal with this; it's easy for, e.g., a buildfarm animal's configuration to set up. Discussion: https://postgr.es/m/9594.1578586797@sss.pgh.pa.us
1 parent 9ce77d7 commit e7ee433

File tree

1 file changed

+10
-0
lines changed

1 file changed

+10
-0
lines changed

src/bin/psql/t/010_tab_completion.pl

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,21 @@
77
use IPC::Run qw(pump finish timer);
88
use Data::Dumper;
99

10+
# Do nothing unless Makefile has told us that the build is --with-readline.
1011
if (!defined($ENV{with_readline}) || $ENV{with_readline} ne 'yes')
1112
{
1213
plan skip_all => 'readline is not supported by this build';
1314
}
1415

16+
# Also, skip if user has set environment variable to command that.
17+
# This is mainly intended to allow working around some of the more broken
18+
# versions of libedit --- some users might find them acceptable even if
19+
# they won't pass these tests.
20+
if (defined($ENV{SKIP_READLINE_TESTS}))
21+
{
22+
plan skip_all => 'SKIP_READLINE_TESTS is set';
23+
}
24+
1525
# If we don't have IO::Pty, forget it, because IPC::Run depends on that
1626
# to support pty connections
1727
eval { require IO::Pty; };

0 commit comments

Comments
 (0)