Merge branch 'PGPRO10' into PGPROEE10

Author: vbwagner

contrib/pg_pathman/.github/ISSUE_TEMPLATE.md

@@ -0,0 +1,28 @@
+<!--
+### IMPORTANT: make sure that you:
+
+- are familiar with [known limitations](https://github.com/postgrespro/pg_pathman/wiki/Known-limitations).
+- checked the [faq](https://github.com/postgrespro/pg_pathman/wiki/What-the-FAQ) for common problems.
+-->
+
+
+### Problem description
+
+Explain your problem here (it's always better to provide reproduction steps) ...
+
+
+
+### Environment
+
+<!-- Put the result of (SELECT * FROM pg_extension) below -->
+
+<!-- Put the result of (SELECT version()) below -->
+
+<!-- For Postgres Pro: put the result of (SELECT pgpro_version()) below -->
+
+<!-- For Postgres Pro: put the result of (SELECT pgpro_edition()) below -->
+
+<!-- For pg_pathman 1.4: put the result of (SELECT get_pathman_lib_version()) below -->
+
+<!-- For pg_pathman 1.5: put the result of (SELECT pathman_version()) below -->
+

contrib/pg_pathman/META.json

@@ -2,7 +2,7 @@
    "name": "pg_pathman",
    "abstract": "Partitioning tool",
    "description": "The `pg_pathman` module provides optimized partitioning mechanism and functions to manage partitions.",
-   "version": "1.4.7",
+   "version": "1.4.9",
    "maintainer": [
       "Ildar Musin <i.musin@postgrespro.ru>",
       "Dmitry Ivanov <d.ivanov@postgrespro.ru>",
@@ -24,7 +24,7 @@
        "pg_pathman": {
            "file": "pg_pathman--1.4.sql",
            "docfile": "README.md",
-           "version": "1.4.7",
+           "version": "1.4.9",
            "abstract": "Partitioning tool"
       }
    },

contrib/pg_pathman/Makefile

@@ -7,7 +7,7 @@ OBJS = src/init.o src/relation_info.o src/utils.o src/partition_filter.o \
 	src/pl_funcs.o src/pl_range_funcs.o src/pl_hash_funcs.o src/pathman_workers.o \
 	src/hooks.o src/nodes_common.o src/xact_handling.o src/utility_stmt_hooking.o \
 	src/planner_tree_modification.o src/debug_print.o src/partition_creation.o \
-	src/compat/pg_compat.o src/compat/relation_tags.o src/compat/rowmarks_fix.o \
+	src/compat/pg_compat.o src/compat/rowmarks_fix.o \
 	$(WIN32RES)
 
 ifdef USE_PGXS

contrib/pg_pathman/README.md

@@ -53,7 +53,7 @@ More interesting features are yet to come. Stay tuned!
  * `RuntimeAppend` & `RuntimeMergeAppend` custom plan nodes to pick partitions at runtime;
  * `PartitionFilter`: an efficient drop-in replacement for INSERT triggers;
  * Automatic partition creation for new INSERTed data (only for RANGE partitioning);
- * Improved `COPY FROM\TO` statement that is able to insert rows directly into partitions;
+ * Improved `COPY FROM` statement that is able to insert rows directly into partitions;
  * UPDATE triggers generation out of the box (will be replaced with custom nodes too);
  * User-defined callbacks for partition creation event handling;
  * Non-blocking concurrent table partitioning;

contrib/pg_pathman/expected/pathman_bgw.out

@@ -187,6 +187,7 @@ DECLARE
 	i			int4 := 0; -- protect from endless loop
 BEGIN
 	LOOP
+		-- get total number of processed rows
 		SELECT processed
 		FROM pathman_concurrent_part_tasks
 		WHERE relid = 'test_bgw.conc_part'::regclass
@@ -200,9 +201,12 @@ BEGIN
 
 			ASSERT rows IS NOT NULL;
 
-			-- rows should increase!
-			IF rows_old <= rows THEN
+			IF rows_old = rows THEN
 				i = i + 1;
+			ELSIF rows < rows_old THEN
+				RAISE EXCEPTION 'rows is decreasing: new %, old %', rows, rows_old;
+			ELSIF rows > 500 THEN
+				RAISE EXCEPTION 'processed % rows', rows;
 			END IF;
 		ELSE
 			EXIT; -- exit loop

contrib/pg_pathman/expected/pathman_calamity.out

@@ -12,7 +12,7 @@ SELECT debug_capture();
 SELECT get_pathman_lib_version();
  get_pathman_lib_version 
 -------------------------
- 10407
+ 10409
 (1 row)
 
 set client_min_messages = NOTICE;

contrib/pg_pathman/expected/pathman_inserts.out

@@ -1032,6 +1032,36 @@ INSERT INTO test_inserts.test_gap VALUES(15); /* not ok */
 ERROR:  cannot spawn a partition
 DROP TABLE test_inserts.test_gap CASCADE;
 NOTICE:  drop cascades to 3 other objects
+/* test a few "special" ONLY queries used in pg_repack */
+CREATE TABLE test_inserts.test_special_only(val INT NOT NULL);
+INSERT INTO test_inserts.test_special_only SELECT generate_series(1, 30);
+SELECT create_hash_partitions('test_inserts.test_special_only', 'val', 4);
+ create_hash_partitions 
+------------------------
+                      4
+(1 row)
+
+/* create table as select only */
+CREATE TABLE test_inserts.special_1 AS SELECT * FROM ONLY test_inserts.test_special_only;
+SELECT count(*) FROM test_inserts.special_1;
+ count 
+-------
+     0
+(1 row)
+
+DROP TABLE test_inserts.special_1;
+/* insert into ... select only */
+CREATE TABLE test_inserts.special_2 AS SELECT * FROM ONLY test_inserts.test_special_only WITH NO DATA;
+INSERT INTO test_inserts.special_2 SELECT * FROM ONLY test_inserts.test_special_only;
+SELECT count(*) FROM test_inserts.special_2;
+ count 
+-------
+     0
+(1 row)
+
+DROP TABLE test_inserts.special_2;
+DROP TABLE test_inserts.test_special_only CASCADE;
+NOTICE:  drop cascades to 4 other objects
 DROP SCHEMA test_inserts CASCADE;
 NOTICE:  drop cascades to 19 other objects
 DROP EXTENSION pg_pathman CASCADE;

contrib/pg_pathman/expected/pathman_inserts_1.out

@@ -1032,6 +1032,36 @@ INSERT INTO test_inserts.test_gap VALUES(15); /* not ok */
 ERROR:  cannot spawn a partition
 DROP TABLE test_inserts.test_gap CASCADE;
 NOTICE:  drop cascades to 3 other objects
+/* test a few "special" ONLY queries used in pg_repack */
+CREATE TABLE test_inserts.test_special_only(val INT NOT NULL);
+INSERT INTO test_inserts.test_special_only SELECT generate_series(1, 30);
+SELECT create_hash_partitions('test_inserts.test_special_only', 'val', 4);
+ create_hash_partitions 
+------------------------
+                      4
+(1 row)
+
+/* create table as select only */
+CREATE TABLE test_inserts.special_1 AS SELECT * FROM ONLY test_inserts.test_special_only;
+SELECT count(*) FROM test_inserts.special_1;
+ count 
+-------
+     0
+(1 row)
+
+DROP TABLE test_inserts.special_1;
+/* insert into ... select only */
+CREATE TABLE test_inserts.special_2 AS SELECT * FROM ONLY test_inserts.test_special_only WITH NO DATA;
+INSERT INTO test_inserts.special_2 SELECT * FROM ONLY test_inserts.test_special_only;
+SELECT count(*) FROM test_inserts.special_2;
+ count 
+-------
+     0
+(1 row)
+
+DROP TABLE test_inserts.special_2;
+DROP TABLE test_inserts.test_special_only CASCADE;
+NOTICE:  drop cascades to 4 other objects
 DROP SCHEMA test_inserts CASCADE;
 NOTICE:  drop cascades to 19 other objects
 DROP EXTENSION pg_pathman CASCADE;

contrib/pg_pathman/expected/pathman_only.out

@@ -137,7 +137,34 @@ UNION SELECT * FROM test_only.from_only_test;
 EXPLAIN (COSTS OFF)
 SELECT * FROM test_only.from_only_test a
 JOIN ONLY test_only.from_only_test b USING(val);
-ERROR:  it is prohibited to apply ONLY modifier to partitioned tables which have already been mentioned without ONLY
+                 QUERY PLAN                  
+---------------------------------------------
+ Nested Loop
+   ->  Seq Scan on from_only_test b
+   ->  Custom Scan (RuntimeAppend)
+         Prune by: (b.val = a.val)
+         ->  Seq Scan on from_only_test_1 a
+               Filter: (b.val = val)
+         ->  Seq Scan on from_only_test_2 a
+               Filter: (b.val = val)
+         ->  Seq Scan on from_only_test_3 a
+               Filter: (b.val = val)
+         ->  Seq Scan on from_only_test_4 a
+               Filter: (b.val = val)
+         ->  Seq Scan on from_only_test_5 a
+               Filter: (b.val = val)
+         ->  Seq Scan on from_only_test_6 a
+               Filter: (b.val = val)
+         ->  Seq Scan on from_only_test_7 a
+               Filter: (b.val = val)
+         ->  Seq Scan on from_only_test_8 a
+               Filter: (b.val = val)
+         ->  Seq Scan on from_only_test_9 a
+               Filter: (b.val = val)
+         ->  Seq Scan on from_only_test_10 a
+               Filter: (b.val = val)
+(24 rows)
+
 /* should be OK */
 EXPLAIN (COSTS OFF)
 WITH q1 AS (SELECT * FROM test_only.from_only_test),