Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit e9c936f

Browse files
committed
Remove rangechecks on errno; just call strerror unconditionally. This
eliminates a raft of portability issues, including whether sys_nerr exists, whether the platform has any valid negative errnos, etc. The downside is minimal: errno shouldn't ever contain an invalid value anyway, and if it does, reasonably modern versions of strerror will not choke. This rangecheck idea seemed good at the time, but it's clearly a net loss, and I apologize to all concerned for having ever put it in.
1 parent 60b282f commit e9c936f

File tree

6 files changed

+53
-130
lines changed

6 files changed

+53
-130
lines changed

config/c-library.m4

Lines changed: 1 addition & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# Macros that test various C library quirks
2-
# $Header: /cvsroot/pgsql/config/c-library.m4,v 1.7 2001/01/10 17:07:18 petere Exp $
2+
# $Header: /cvsroot/pgsql/config/c-library.m4,v 1.8 2001/01/22 23:28:50 tgl Exp $
33

44

55
# PGAC_VAR_INT_TIMEZONE
@@ -124,19 +124,3 @@ if test x"$pgac_cv_header_strings_both" = x"yes"; then
124124
AC_DEFINE([STRING_H_WITH_STRINGS_H], 1,
125125
[Define if string.h and strings.h may both be included])
126126
fi])
127-
128-
129-
# PGAC_VAR_SYS_NERR
130-
# -----------------
131-
# Check if the global variable 'sys_nerr' exists. If so, define
132-
# HAVE_SYS_NERR.
133-
AC_DEFUN([PGAC_VAR_SYS_NERR],
134-
[AC_CACHE_CHECK([for sys_nerr], pgac_cv_var_sys_nerr,
135-
[AC_TRY_LINK([extern int sys_nerr;
136-
int x;],
137-
[x = sys_nerr;],
138-
[pgac_cv_var_sys_nerr=yes],
139-
[pgac_cv_var_sys_nerr=no])])
140-
if test x"$pgac_cv_var_sys_nerr" = xyes ; then
141-
AC_DEFINE(HAVE_SYS_NERR,, [Set to 1 if you have the global variable sys_nerr])
142-
fi])# PGAC_VAR_SYS_NERR

0 commit comments

Comments
 (0)