Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit ec8f692

Browse files
committed
Fix alignment of GIN in-line posting lists stored in entry tuples.
The Sparc machines in the buildfarm are crashing because of misaligned access to posting lists stored in entry tuples. I accidentally removed a critical SHORTALIGN() from ginFormTuple, as part of the packed posting lists patch. Perhaps I thought it was unnecessary, because the index_form_tuple() call above the SHORTALIGN already aligned the size, missing the fact that the null-category byte makes it misaligned again (I think the SHORTALIGN is indeed unnecessary if there's no null- category byte, but let's just play it safe...)
1 parent 0fdb2f7 commit ec8f692

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

src/backend/access/gin/ginentrypage.c

+2
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,8 @@ GinFormTuple(GinState *ginstate,
8787
newsize = Max(newsize, minsize);
8888
}
8989

90+
newsize = SHORTALIGN(newsize);
91+
9092
GinSetPostingOffset(itup, newsize);
9193
GinSetNPosting(itup, nipd);
9294

0 commit comments

Comments
 (0)