Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit f024746

Browse files
committed
Bound waits in 035_standby_logical_decoding.pl.
One IPC::Run::start() used an IPC::Run::timer() without checking for expiration. The other used no timeout or timer. Back-patch to v16, which introduced the test. Reviewed by Bertrand Drouvot. Discussion: https://postgr.es/m/20240211010227.a2.nmisch@google.com
1 parent 6257ebf commit f024746

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/test/recovery/t/035_standby_logical_decoding.pl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121
PostgreSQL::Test::Cluster->new('cascading_standby');
2222
my $node_subscriber = PostgreSQL::Test::Cluster->new('subscriber');
2323
my $default_timeout = $PostgreSQL::Test::Utils::timeout_default;
24-
my $psql_timeout = IPC::Run::timer($default_timeout);
2524
my $res;
2625

2726
# Name for the physical slot on primary
@@ -90,7 +89,8 @@ sub make_slot_active
9089
'>',
9190
$to_stdout,
9291
'2>',
93-
$to_stderr);
92+
$to_stderr,
93+
IPC::Run::timeout($default_timeout));
9494

9595
if ($wait)
9696
{
@@ -343,7 +343,7 @@ sub wait_until_vacuum_can_remove
343343
\$psql_subscriber{subscriber_stdout},
344344
'2>',
345345
\$psql_subscriber{subscriber_stderr},
346-
$psql_timeout);
346+
IPC::Run::timeout($default_timeout));
347347

348348
##################################################
349349
# Test that logical decoding on the standby

0 commit comments

Comments
 (0)