Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit f172b11

Browse files
committed
Remove no-longer-used parameter for create_groupingsets_path().
numGroups is unused since commit b563594; let's get rid of it. XueJing Zhao, reviewed by Richard Guo Discussion: https://postgr.es/m/DM6PR05MB64923CC8B63A2CAF3B2E5D47B7AD9@DM6PR05MB6492.namprd05.prod.outlook.com
1 parent f58f1fb commit f172b11

File tree

3 files changed

+5
-11
lines changed

3 files changed

+5
-11
lines changed

src/backend/optimizer/plan/planner.c

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3900,8 +3900,7 @@ consider_groupingsets_paths(PlannerInfo *root,
39003900
(List *) parse->havingQual,
39013901
strat,
39023902
new_rollups,
3903-
agg_costs,
3904-
dNumGroups));
3903+
agg_costs));
39053904
return;
39063905
}
39073906

@@ -4059,8 +4058,7 @@ consider_groupingsets_paths(PlannerInfo *root,
40594058
(List *) parse->havingQual,
40604059
AGG_MIXED,
40614060
rollups,
4062-
agg_costs,
4063-
dNumGroups));
4061+
agg_costs));
40644062
}
40654063
}
40664064

@@ -4075,8 +4073,7 @@ consider_groupingsets_paths(PlannerInfo *root,
40754073
(List *) parse->havingQual,
40764074
AGG_SORTED,
40774075
gd->rollups,
4078-
agg_costs,
4079-
dNumGroups));
4076+
agg_costs));
40804077
}
40814078

40824079
/*

src/backend/optimizer/util/pathnode.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3158,7 +3158,6 @@ create_agg_path(PlannerInfo *root,
31583158
* 'having_qual' is the HAVING quals if any
31593159
* 'rollups' is a list of RollupData nodes
31603160
* 'agg_costs' contains cost info about the aggregate functions to be computed
3161-
* 'numGroups' is the estimated total number of groups
31623161
*/
31633162
GroupingSetsPath *
31643163
create_groupingsets_path(PlannerInfo *root,
@@ -3167,8 +3166,7 @@ create_groupingsets_path(PlannerInfo *root,
31673166
List *having_qual,
31683167
AggStrategy aggstrategy,
31693168
List *rollups,
3170-
const AggClauseCosts *agg_costs,
3171-
double numGroups)
3169+
const AggClauseCosts *agg_costs)
31723170
{
31733171
GroupingSetsPath *pathnode = makeNode(GroupingSetsPath);
31743172
PathTarget *target = rel->reltarget;

src/include/optimizer/pathnode.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -233,8 +233,7 @@ extern GroupingSetsPath *create_groupingsets_path(PlannerInfo *root,
233233
List *having_qual,
234234
AggStrategy aggstrategy,
235235
List *rollups,
236-
const AggClauseCosts *agg_costs,
237-
double numGroups);
236+
const AggClauseCosts *agg_costs);
238237
extern MinMaxAggPath *create_minmaxagg_path(PlannerInfo *root,
239238
RelOptInfo *rel,
240239
PathTarget *target,

0 commit comments

Comments
 (0)