Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit f36b636

Browse files
committed
Remove more statements from stats.sql
Some of the statements capturing stats reset timestamps have become unnecessary after a9a8108, so let's remove them. Author: Bharath Rupireddy Discussion: https://postgr.es/m/CALj2ACUnvB_Yo=O1xApBa4CDqQpW-x=QM35GBN1MqVRAxAGXEg@mail.gmail.com
1 parent 60f2273 commit f36b636

File tree

2 files changed

+0
-12
lines changed

2 files changed

+0
-12
lines changed

src/test/regress/expected/stats.out

-6
Original file line numberDiff line numberDiff line change
@@ -914,7 +914,6 @@ SELECT stats_reset > :'archiver_reset_ts'::timestamptz FROM pg_stat_archiver;
914914
t
915915
(1 row)
916916

917-
SELECT stats_reset AS archiver_reset_ts FROM pg_stat_archiver \gset
918917
-- Test that reset_shared with bgwriter specified as the stats type works
919918
SELECT stats_reset AS bgwriter_reset_ts FROM pg_stat_bgwriter \gset
920919
SELECT pg_stat_reset_shared('bgwriter');
@@ -929,7 +928,6 @@ SELECT stats_reset > :'bgwriter_reset_ts'::timestamptz FROM pg_stat_bgwriter;
929928
t
930929
(1 row)
931930

932-
SELECT stats_reset AS bgwriter_reset_ts FROM pg_stat_bgwriter \gset
933931
-- Test that reset_shared with checkpointer specified as the stats type works
934932
SELECT stats_reset AS checkpointer_reset_ts FROM pg_stat_checkpointer \gset
935933
SELECT pg_stat_reset_shared('checkpointer');
@@ -944,7 +942,6 @@ SELECT stats_reset > :'checkpointer_reset_ts'::timestamptz FROM pg_stat_checkpoi
944942
t
945943
(1 row)
946944

947-
SELECT stats_reset AS checkpointer_reset_ts FROM pg_stat_checkpointer \gset
948945
-- Test that reset_shared with recovery_prefetch specified as the stats type works
949946
SELECT stats_reset AS recovery_prefetch_reset_ts FROM pg_stat_recovery_prefetch \gset
950947
SELECT pg_stat_reset_shared('recovery_prefetch');
@@ -959,7 +956,6 @@ SELECT stats_reset > :'recovery_prefetch_reset_ts'::timestamptz FROM pg_stat_rec
959956
t
960957
(1 row)
961958

962-
SELECT stats_reset AS recovery_prefetch_reset_ts FROM pg_stat_recovery_prefetch \gset
963959
-- Test that reset_shared with slru specified as the stats type works
964960
SELECT max(stats_reset) AS slru_reset_ts FROM pg_stat_slru \gset
965961
SELECT pg_stat_reset_shared('slru');
@@ -974,7 +970,6 @@ SELECT max(stats_reset) > :'slru_reset_ts'::timestamptz FROM pg_stat_slru;
974970
t
975971
(1 row)
976972

977-
SELECT max(stats_reset) AS slru_reset_ts FROM pg_stat_slru \gset
978973
-- Test that reset_shared with wal specified as the stats type works
979974
SELECT stats_reset AS wal_reset_ts FROM pg_stat_wal \gset
980975
SELECT pg_stat_reset_shared('wal');
@@ -989,7 +984,6 @@ SELECT stats_reset > :'wal_reset_ts'::timestamptz FROM pg_stat_wal;
989984
t
990985
(1 row)
991986

992-
SELECT stats_reset AS wal_reset_ts FROM pg_stat_wal \gset
993987
-- Test error case for reset_shared with unknown stats type
994988
SELECT pg_stat_reset_shared('unknown');
995989
ERROR: unrecognized reset target: "unknown"

src/test/regress/sql/stats.sql

-6
Original file line numberDiff line numberDiff line change
@@ -462,37 +462,31 @@ SELECT stats_reset > :'slru_notify_reset_ts'::timestamptz FROM pg_stat_slru WHER
462462
SELECT stats_reset AS archiver_reset_ts FROM pg_stat_archiver \gset
463463
SELECT pg_stat_reset_shared('archiver');
464464
SELECT stats_reset > :'archiver_reset_ts'::timestamptz FROM pg_stat_archiver;
465-
SELECT stats_reset AS archiver_reset_ts FROM pg_stat_archiver \gset
466465

467466
-- Test that reset_shared with bgwriter specified as the stats type works
468467
SELECT stats_reset AS bgwriter_reset_ts FROM pg_stat_bgwriter \gset
469468
SELECT pg_stat_reset_shared('bgwriter');
470469
SELECT stats_reset > :'bgwriter_reset_ts'::timestamptz FROM pg_stat_bgwriter;
471-
SELECT stats_reset AS bgwriter_reset_ts FROM pg_stat_bgwriter \gset
472470

473471
-- Test that reset_shared with checkpointer specified as the stats type works
474472
SELECT stats_reset AS checkpointer_reset_ts FROM pg_stat_checkpointer \gset
475473
SELECT pg_stat_reset_shared('checkpointer');
476474
SELECT stats_reset > :'checkpointer_reset_ts'::timestamptz FROM pg_stat_checkpointer;
477-
SELECT stats_reset AS checkpointer_reset_ts FROM pg_stat_checkpointer \gset
478475

479476
-- Test that reset_shared with recovery_prefetch specified as the stats type works
480477
SELECT stats_reset AS recovery_prefetch_reset_ts FROM pg_stat_recovery_prefetch \gset
481478
SELECT pg_stat_reset_shared('recovery_prefetch');
482479
SELECT stats_reset > :'recovery_prefetch_reset_ts'::timestamptz FROM pg_stat_recovery_prefetch;
483-
SELECT stats_reset AS recovery_prefetch_reset_ts FROM pg_stat_recovery_prefetch \gset
484480

485481
-- Test that reset_shared with slru specified as the stats type works
486482
SELECT max(stats_reset) AS slru_reset_ts FROM pg_stat_slru \gset
487483
SELECT pg_stat_reset_shared('slru');
488484
SELECT max(stats_reset) > :'slru_reset_ts'::timestamptz FROM pg_stat_slru;
489-
SELECT max(stats_reset) AS slru_reset_ts FROM pg_stat_slru \gset
490485

491486
-- Test that reset_shared with wal specified as the stats type works
492487
SELECT stats_reset AS wal_reset_ts FROM pg_stat_wal \gset
493488
SELECT pg_stat_reset_shared('wal');
494489
SELECT stats_reset > :'wal_reset_ts'::timestamptz FROM pg_stat_wal;
495-
SELECT stats_reset AS wal_reset_ts FROM pg_stat_wal \gset
496490

497491
-- Test error case for reset_shared with unknown stats type
498492
SELECT pg_stat_reset_shared('unknown');

0 commit comments

Comments
 (0)