Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit f583633

Browse files
committed
Fix breakage in AlterFunction().
An ALTER FUNCTION command that tried to update both the function's proparallel property and its proconfig list failed to do the former, because it stored the new proparallel value into a tuple that was no longer the interesting one. Carelessness in 7aea8e4. (I did not bother with a regression test, because the only likely future breakage would be for someone to ignore the comment I added and add some other field update after the heap_modify_tuple step. A test using existing function properties could not catch that.) Per report from Bryn Llewellyn. Back-patch to all supported branches. Discussion: https://postgr.es/m/8AC9A37F-99BD-446F-A2F7-B89AD0022774@yugabyte.com
1 parent 82d4a17 commit f583633

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

src/backend/commands/functioncmds.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1354,6 +1354,8 @@ AlterFunction(ParseState *pstate, AlterFunctionStmt *stmt)
13541354

13551355
procForm->prosupport = newsupport;
13561356
}
1357+
if (parallel_item)
1358+
procForm->proparallel = interpret_func_parallel(parallel_item);
13571359
if (set_items)
13581360
{
13591361
Datum datum;
@@ -1388,8 +1390,7 @@ AlterFunction(ParseState *pstate, AlterFunctionStmt *stmt)
13881390
tup = heap_modify_tuple(tup, RelationGetDescr(rel),
13891391
repl_val, repl_null, repl_repl);
13901392
}
1391-
if (parallel_item)
1392-
procForm->proparallel = interpret_func_parallel(parallel_item);
1393+
/* DO NOT put more touches of procForm below here; it's now dangling. */
13931394

13941395
/* Do the update */
13951396
CatalogTupleUpdate(rel, &tup->t_self, tup);

0 commit comments

Comments
 (0)