Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit f854dae

Browse files
committed
Improve comment about query_id_enabled in queryjumblefuncs.c
The comment was inexact because query_id_enabled will not be switched to "true" even if compute_query_id is "on", unless a module requests for it. While on it, this adds a comment to mention that IsQueryIdEnabled() should be used to check if query ID computation is enabled or not. Author: Yugo Nagata Reviewed-by: Julien Rouhaud Discussion: https://postgr.es/m/20240209153823.e29a68cadb14225f1362a2cf@sraoss.co.jp
1 parent 5ebc9c9 commit f854dae

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

src/backend/nodes/queryjumblefuncs.c

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,13 @@
4242
/* GUC parameters */
4343
int compute_query_id = COMPUTE_QUERY_ID_AUTO;
4444

45-
/* True when compute_query_id is ON, or AUTO and a module requests them */
45+
/*
46+
* True when compute_query_id is ON or AUTO, and a module requests them.
47+
*
48+
* Note that IsQueryIdEnabled() should be used instead of checking
49+
* query_id_enabled or compute_query_id directly when we want to know
50+
* whether query identifiers are computed in the core or not.
51+
*/
4652
bool query_id_enabled = false;
4753

4854
static void AppendJumble(JumbleState *jstate,

0 commit comments

Comments
 (0)