Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit f97f0c9

Browse files
committed
Adjust _bt_insertonpg() comments
Remove an obsolete reference to the 'afteritem' argument, which was removed by commit bc29293. Add a comment that clarifies how _bt_insertonpg() indirectly handles the insertion of high key items. Author: Peter Geoghegan
1 parent 3d92796 commit f97f0c9

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

src/backend/access/nbtree/nbtinsert.c

+6-6
Original file line numberDiff line numberDiff line change
@@ -817,18 +817,18 @@ _bt_findinsertloc(Relation rel,
817817
* insertion, and the buffer must be pinned and write-locked. On return,
818818
* we will have dropped both the pin and the lock on the buffer.
819819
*
820-
* When inserting to a non-leaf page, 'cbuf' is the left-sibling of the
821-
* page we're inserting the downlink for. This function will clear the
820+
* This routine only performs retail tuple insertions. 'itup' should
821+
* always be either a non-highkey leaf item, or a downlink (new high
822+
* key items are created indirectly, when a page is split). When
823+
* inserting to a non-leaf page, 'cbuf' is the left-sibling of the page
824+
* we're inserting the downlink for. This function will clear the
822825
* INCOMPLETE_SPLIT flag on it, and release the buffer.
823826
*
824827
* The locking interactions in this code are critical. You should
825828
* grok Lehman and Yao's paper before making any changes. In addition,
826829
* you need to understand how we disambiguate duplicate keys in this
827830
* implementation, in order to be able to find our location using
828-
* L&Y "move right" operations. Since we may insert duplicate user
829-
* keys, and since these dups may propagate up the tree, we use the
830-
* 'afteritem' parameter to position ourselves correctly for the
831-
* insertion on internal pages.
831+
* L&Y "move right" operations.
832832
*----------
833833
*/
834834
static void

0 commit comments

Comments
 (0)