* construct "struct {} list [] = {}" confuses pgindent - split those.

  It was a bad style to begin with, and now several loops can be clearer.
* pgcrypto.c: Fix function comments
* crypt-gensalt.c, crypt-blowfish.c: stop messing with errno
* openssl.c: use px_free instead pfree
* px.h: make redefining px_alloc/px_realloc/px_free easier

Marko Kreen

Author: Neil Conway

contrib/pgcrypto/crypt-blowfish.c

@@ -35,12 +35,6 @@
 #include "px.h"
 #include "px-crypt.h"
 
-#define __set_errno(v)
-
-#ifndef __set_errno
-#define __set_errno(val) errno = (val)
-#endif
-
 #ifdef __i386__
 #define BF_ASM				0	/* 1 */
 #define BF_SCALE			1
@@ -600,10 +594,7 @@ _crypt_blowfish_rn(const char *key, const char *setting,
 	int			i;
 
 	if (size < 7 + 22 + 31 + 1)
-	{
-		__set_errno(ERANGE);
 		return NULL;
-	}
 
 	if (setting[0] != '$' ||
 		setting[1] != '2' ||
@@ -613,15 +604,13 @@ _crypt_blowfish_rn(const char *key, const char *setting,
 		setting[5] < '0' || setting[5] > '9' ||
 		setting[6] != '$')
 	{
-		__set_errno(EINVAL);
 		return NULL;
 	}
 
 	count = (BF_word) 1 << ((setting[4] - '0') * 10 + (setting[5] - '0'));
 	if (count < 16 || BF_decode(data.binary.salt, &setting[7], 16))
 	{
 		memset(data.binary.salt, 0, sizeof(data.binary.salt));
-		__set_errno(EINVAL);
 		return NULL;
 	}
 	BF_swap(data.binary.salt, 4);

contrib/pgcrypto/crypt-gensalt.c

@@ -15,11 +15,6 @@
 #include "px.h"
 #include "px-crypt.h"
 
-#include <errno.h>
-#ifndef __set_errno
-#define __set_errno(val) (errno = (val))
-#endif
-
 typedef unsigned int BF_word;
 
 unsigned char _crypt_itoa64[64 + 1] =
@@ -33,7 +28,6 @@ _crypt_gensalt_traditional_rn(unsigned long count,
 	{
 		if (output_size > 0)
 			output[0] = '\0';
-		__set_errno((output_size < 2 + 1) ? ERANGE : EINVAL);
 		return NULL;
 	}
 
@@ -57,7 +51,6 @@ _crypt_gensalt_extended_rn(unsigned long count,
 	{
 		if (output_size > 0)
 			output[0] = '\0';
-		__set_errno((output_size < 1 + 4 + 4 + 1) ? ERANGE : EINVAL);
 		return NULL;
 	}
 
@@ -91,7 +84,6 @@ _crypt_gensalt_md5_rn(unsigned long count,
 	{
 		if (output_size > 0)
 			output[0] = '\0';
-		__set_errno((output_size < 3 + 4 + 1) ? ERANGE : EINVAL);
 		return NULL;
 	}
 
@@ -173,7 +165,6 @@ _crypt_gensalt_blowfish_rn(unsigned long count,
 	{
 		if (output_size > 0)
 			output[0] = '\0';
-		__set_errno((output_size < 7 + 22 + 1) ? ERANGE : EINVAL);
 		return NULL;
 	}
 

contrib/pgcrypto/internal.c

@@ -26,7 +26,7 @@
  * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
  * SUCH DAMAGE.
  *
- * $PostgreSQL: pgsql/contrib/pgcrypto/internal.c,v 1.14 2004/10/25 02:15:02 tgl Exp $
+ * $PostgreSQL: pgsql/contrib/pgcrypto/internal.c,v 1.15 2005/03/21 05:18:45 neilc Exp $
  */
 
 
@@ -57,22 +57,17 @@
 static void init_md5(PX_MD * h);
 static void init_sha1(PX_MD * h);
 
-static struct int_digest
+struct int_digest
 {
 	char	   *name;
 	void		(*init) (PX_MD * h);
-}	int_digest_list[] =
+};
 
-{
-	{
-		"md5", init_md5
-	},
-	{
-		"sha1", init_sha1
-	},
-	{
-		NULL, NULL
-	}
+static const struct int_digest
+int_digest_list[] = {
+	{ "md5", init_md5 },
+	{ "sha1", init_sha1 },
+	{ NULL, NULL }
 };
 
 /* MD5 */
@@ -516,31 +511,22 @@ bf_cbc_load(void)
 	return bf_load(MODE_CBC);
 }
 
-static struct
+struct int_cipher
 {
 	char	   *name;
 	PX_Cipher  *(*load) (void);
-}	int_ciphers[] =
+};
 
-{
-	{
-		"bf-cbc", bf_cbc_load
-	},
-	{
-		"bf-ecb", bf_ecb_load
-	},
-	{
-		"aes-128-cbc", rj_128_cbc
-	},
-	{
-		"aes-128-ecb", rj_128_ecb
-	},
-	{
-		NULL, NULL
-	}
+static const struct int_cipher
+int_ciphers[] = {
+	{ "bf-cbc", bf_cbc_load },
+	{ "bf-ecb", bf_ecb_load },
+	{ "aes-128-cbc", rj_128_cbc },
+	{ "aes-128-ecb", rj_128_ecb },
+	{ NULL, NULL }
 };
 
-static PX_Alias int_aliases[] = {
+static const PX_Alias int_aliases[] = {
 	{"bf", "bf-cbc"},
 	{"blowfish", "bf-cbc"},
 	{"aes", "aes-128-cbc"},
@@ -557,7 +543,7 @@ static PX_Alias int_aliases[] = {
 int
 px_find_digest(const char *name, PX_MD ** res)
 {
-	struct int_digest *p;
+	const struct int_digest *p;
 	PX_MD	   *h;
 
 	for (p = int_digest_list; p->name; p++)

contrib/pgcrypto/openssl.c

@@ -26,7 +26,7 @@
  * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
  * SUCH DAMAGE.
  *
- * $PostgreSQL: pgsql/contrib/pgcrypto/openssl.c,v 1.14 2005/03/12 06:53:54 neilc Exp $
+ * $PostgreSQL: pgsql/contrib/pgcrypto/openssl.c,v 1.15 2005/03/21 05:18:45 neilc Exp $
  */
 
 #include <postgres.h>
@@ -208,8 +208,8 @@ gen_ossl_free(PX_Cipher * c)
 	ossldata   *od = (ossldata *) c->ptr;
 
 	memset(od, 0, sizeof(*od));
-	pfree(od);
-	pfree(c);
+	px_free(od);
+	px_free(c);
 }
 
 /* Blowfish */
@@ -473,76 +473,51 @@ static const struct ossl_cipher ossl_cast_cbc = {
 /*
  * Special handlers
  */
-static const struct
+struct ossl_cipher_lookup
 {
 	const char *name;
 	const struct ossl_cipher *ciph;
-}	ossl_cipher_types[] =
+};
 
-{
-	{
-		"bf-cbc", &ossl_bf_cbc
-	},
-	{
-		"bf-ecb", &ossl_bf_ecb
-	},
-	{
-		"bf-cfb", &ossl_bf_cfb
-	},
-	{
-		"des-ecb", &ossl_des_ecb
-	},
-	{
-		"des-cbc", &ossl_des_cbc
-	},
-	{
-		"cast5-ecb", &ossl_cast_ecb
-	},
-	{
-		"cast5-cbc", &ossl_cast_cbc
-	},
-	{
-		NULL
-	}
+static const struct ossl_cipher_lookup ossl_cipher_types[] = {
+	{"bf-cbc", &ossl_bf_cbc},
+	{"bf-ecb", &ossl_bf_ecb},
+	{"bf-cfb", &ossl_bf_cfb},
+	{"des-ecb", &ossl_des_ecb},
+	{"des-cbc", &ossl_des_cbc},
+	{"cast5-ecb", &ossl_cast_ecb},
+	{"cast5-cbc", &ossl_cast_cbc},
+	{NULL}
 };
 
 /* PUBLIC functions */
 
 int
 px_find_cipher(const char *name, PX_Cipher ** res)
 {
-	unsigned	i;
-	PX_Cipher  *c = NULL,
-			   *csrc;
+	const struct ossl_cipher_lookup *i;
+	PX_Cipher  *c = NULL;
 	ossldata   *od;
-	const struct ossl_cipher *ossl_ciph = NULL;
 
 	name = px_resolve_alias(ossl_aliases, name);
-	for (i = 0; ossl_cipher_types[i].name; i++)
-	{
-		if (!strcmp(ossl_cipher_types[i].name, name))
-		{
-			ossl_ciph = ossl_cipher_types[i].ciph;
+	for (i = ossl_cipher_types; i->name; i++)
+		if (!strcmp(i->name, name))
 			break;
-		}
-	}
-	if (ossl_ciph == NULL)
+	if (i->name == NULL)
 		return -1;
 
 	od = px_alloc(sizeof(*od));
 	memset(od, 0, sizeof(*od));
-	od->ciph = ossl_ciph;
-
-	csrc = NULL;
+	od->ciph = i->ciph;
 
 	c = px_alloc(sizeof(*c));
 	c->block_size = gen_ossl_block_size;
 	c->key_size = gen_ossl_key_size;
 	c->iv_size = gen_ossl_iv_size;
 	c->free = gen_ossl_free;
-	c->init = ossl_ciph->init;
-	c->encrypt = ossl_ciph->encrypt;
-	c->decrypt = ossl_ciph->decrypt;
+	c->init = od->ciph->init;
+	c->encrypt = od->ciph->encrypt;
+	c->decrypt = od->ciph->decrypt;
 	c->ptr = od;
 
 	*res = c;

contrib/pgcrypto/pgcrypto.c

@@ -26,7 +26,7 @@
  * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
  * SUCH DAMAGE.
  *
- * $PostgreSQL: pgsql/contrib/pgcrypto/pgcrypto.c,v 1.16 2004/05/07 00:24:57 tgl Exp $
+ * $PostgreSQL: pgsql/contrib/pgcrypto/pgcrypto.c,v 1.17 2005/03/21 05:18:45 neilc Exp $
  */
 
 #include "postgres.h"
@@ -46,7 +46,7 @@ typedef int (*PFN) (const char *name, void **res);
 static void *
 			find_provider(text *name, PFN pf, char *desc, int silent);
 
-/* SQL function: hash(text, text) returns text */
+/* SQL function: hash(bytea, text) returns bytea */
 PG_FUNCTION_INFO_V1(pg_digest);
 
 Datum
@@ -111,7 +111,7 @@ pg_digest_exists(PG_FUNCTION_ARGS)
 	PG_RETURN_BOOL(true);
 }
 
-/* SQL function: hmac(data:text, key:text, type:text) */
+/* SQL function: hmac(data:bytea, key:bytea, type:text) returns bytea */
 PG_FUNCTION_INFO_V1(pg_hmac);
 
 Datum
@@ -316,7 +316,7 @@ pg_crypt(PG_FUNCTION_ARGS)
 	PG_RETURN_TEXT_P(res);
 }
 
-/* SQL function: pg_encrypt(text, text, text) returns text */
+/* SQL function: pg_encrypt(bytea, bytea, text) returns bytea */
 PG_FUNCTION_INFO_V1(pg_encrypt);
 
 Datum
@@ -367,7 +367,7 @@ pg_encrypt(PG_FUNCTION_ARGS)
 	PG_RETURN_BYTEA_P(res);
 }
 
-/* SQL function: pg_decrypt(text, text, text) returns text */
+/* SQL function: pg_decrypt(bytea, bytea, text) returns bytea */
 PG_FUNCTION_INFO_V1(pg_decrypt);
 
 Datum
@@ -417,7 +417,7 @@ pg_decrypt(PG_FUNCTION_ARGS)
 	PG_RETURN_BYTEA_P(res);
 }
 
-/* SQL function: pg_encrypt(text, text, text) returns text */
+/* SQL function: pg_encrypt_iv(bytea, bytea, bytea, text) returns bytea */
 PG_FUNCTION_INFO_V1(pg_encrypt_iv);
 
 Datum
@@ -473,7 +473,7 @@ pg_encrypt_iv(PG_FUNCTION_ARGS)
 	PG_RETURN_BYTEA_P(res);
 }
 
-/* SQL function: pg_decrypt_iv(text, text, text) returns text */
+/* SQL function: pg_decrypt_iv(bytea, bytea, bytea, text) returns bytea */
 PG_FUNCTION_INFO_V1(pg_decrypt_iv);
 
 Datum
@@ -529,7 +529,7 @@ pg_decrypt_iv(PG_FUNCTION_ARGS)
 	PG_RETURN_BYTEA_P(res);
 }
 
-/* SQL function: pg_decrypt(text, text, text) returns text */
+/* SQL function: pg_cipher_exists(text) returns bool */
 PG_FUNCTION_INFO_V1(pg_cipher_exists);
 
 Datum
@@ -550,7 +550,6 @@ pg_cipher_exists(PG_FUNCTION_ARGS)
 	PG_RETURN_BOOL((c != NULL) ? true : false);
 }
 
-
 static void *
 find_provider(text *name,
 			  PFN provider_lookup,