Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit fb17eab

Browse files
committed
Fix earthdistance test suite function name typo.
Affected test queries have been testing the wrong thing since their introduction in commit 4c1383e. Back-patch to 9.3 (all supported versions).
1 parent 59eb12c commit fb17eab

File tree

2 files changed

+28
-24
lines changed

2 files changed

+28
-24
lines changed

contrib/earthdistance/expected/earthdistance.out

+24-20
Original file line numberDiff line numberDiff line change
@@ -882,11 +882,12 @@ SELECT earth_box(ll_to_earth(90,180),
882882
--
883883
-- Test the recommended constraints.
884884
--
885-
SELECT is_point(ll_to_earth(0,0));
886-
ERROR: function is_point(earth) does not exist
887-
LINE 1: SELECT is_point(ll_to_earth(0,0));
888-
^
889-
HINT: No function matches the given name and argument types. You might need to add explicit type casts.
885+
SELECT cube_is_point(ll_to_earth(0,0));
886+
cube_is_point
887+
---------------
888+
t
889+
(1 row)
890+
890891
SELECT cube_dim(ll_to_earth(0,0)) <= 3;
891892
?column?
892893
----------
@@ -900,11 +901,12 @@ SELECT abs(cube_distance(ll_to_earth(0,0), '(0)'::cube) / earth() - 1) <
900901
t
901902
(1 row)
902903

903-
SELECT is_point(ll_to_earth(30,60));
904-
ERROR: function is_point(earth) does not exist
905-
LINE 1: SELECT is_point(ll_to_earth(30,60));
906-
^
907-
HINT: No function matches the given name and argument types. You might need to add explicit type casts.
904+
SELECT cube_is_point(ll_to_earth(30,60));
905+
cube_is_point
906+
---------------
907+
t
908+
(1 row)
909+
908910
SELECT cube_dim(ll_to_earth(30,60)) <= 3;
909911
?column?
910912
----------
@@ -918,11 +920,12 @@ SELECT abs(cube_distance(ll_to_earth(30,60), '(0)'::cube) / earth() - 1) <
918920
t
919921
(1 row)
920922

921-
SELECT is_point(ll_to_earth(60,90));
922-
ERROR: function is_point(earth) does not exist
923-
LINE 1: SELECT is_point(ll_to_earth(60,90));
924-
^
925-
HINT: No function matches the given name and argument types. You might need to add explicit type casts.
923+
SELECT cube_is_point(ll_to_earth(60,90));
924+
cube_is_point
925+
---------------
926+
t
927+
(1 row)
928+
926929
SELECT cube_dim(ll_to_earth(60,90)) <= 3;
927930
?column?
928931
----------
@@ -936,11 +939,12 @@ SELECT abs(cube_distance(ll_to_earth(60,90), '(0)'::cube) / earth() - 1) <
936939
t
937940
(1 row)
938941

939-
SELECT is_point(ll_to_earth(-30,-90));
940-
ERROR: function is_point(earth) does not exist
941-
LINE 1: SELECT is_point(ll_to_earth(-30,-90));
942-
^
943-
HINT: No function matches the given name and argument types. You might need to add explicit type casts.
942+
SELECT cube_is_point(ll_to_earth(-30,-90));
943+
cube_is_point
944+
---------------
945+
t
946+
(1 row)
947+
944948
SELECT cube_dim(ll_to_earth(-30,-90)) <= 3;
945949
?column?
946950
----------

contrib/earthdistance/sql/earthdistance.sql

+4-4
Original file line numberDiff line numberDiff line change
@@ -282,19 +282,19 @@ SELECT earth_box(ll_to_earth(90,180),
282282
-- Test the recommended constraints.
283283
--
284284

285-
SELECT is_point(ll_to_earth(0,0));
285+
SELECT cube_is_point(ll_to_earth(0,0));
286286
SELECT cube_dim(ll_to_earth(0,0)) <= 3;
287287
SELECT abs(cube_distance(ll_to_earth(0,0), '(0)'::cube) / earth() - 1) <
288288
'10e-12'::float8;
289-
SELECT is_point(ll_to_earth(30,60));
289+
SELECT cube_is_point(ll_to_earth(30,60));
290290
SELECT cube_dim(ll_to_earth(30,60)) <= 3;
291291
SELECT abs(cube_distance(ll_to_earth(30,60), '(0)'::cube) / earth() - 1) <
292292
'10e-12'::float8;
293-
SELECT is_point(ll_to_earth(60,90));
293+
SELECT cube_is_point(ll_to_earth(60,90));
294294
SELECT cube_dim(ll_to_earth(60,90)) <= 3;
295295
SELECT abs(cube_distance(ll_to_earth(60,90), '(0)'::cube) / earth() - 1) <
296296
'10e-12'::float8;
297-
SELECT is_point(ll_to_earth(-30,-90));
297+
SELECT cube_is_point(ll_to_earth(-30,-90));
298298
SELECT cube_dim(ll_to_earth(-30,-90)) <= 3;
299299
SELECT abs(cube_distance(ll_to_earth(-30,-90), '(0)'::cube) / earth() - 1) <
300300
'10e-12'::float8;

0 commit comments

Comments
 (0)