Fix comment in pg_proc.c

michaelpq · michaelpq · commit fcab82a2d79b · 2022-05-14T08:27:59.000+09:00
pgstat_create_function() creates stats for a function in a transactional fashion, so the stats would be dropped if transaction creating the function is aborted, not committed. Author: Amul Sul Discussion: https://postgr.es/m/CAAJ_b97x1T3xgAMWNj4w7kSgN0nTuG-vLrQJ4NB-dsNr0Kudxw@mail.gmail.com
diff --git a/src/backend/catalog/pg_proc.c b/src/backend/catalog/pg_proc.c
@@ -710,7 +710,7 @@ ProcedureCreate(const char *procedureName,
 			AtEOXact_GUC(true, save_nestlevel);
 	}
 
-	/* ensure that stats are dropped if transaction commits */
+	/* ensure that stats are dropped if transaction aborts */
 	if (!is_update)
 		pgstat_create_function(retval);
 

Original file line number	Diff line number	Diff line change
`@@ -710,7 +710,7 @@ ProcedureCreate(const char *procedureName,`
`710`	`710`	`AtEOXact_GUC(true, save_nestlevel);`
`711`	`711`	`}`
`712`	`712`
`713`		`- /* ensure that stats are dropped if transaction commits */`
	`713`	`+ /* ensure that stats are dropped if transaction aborts */`
`714`	`714`	`if (!is_update)`
`715`	`715`	`pgstat_create_function(retval);`
`716`	`716`