Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit ff9d27e

Browse files
committed
Prevent instability in contrib/pageinspect's regression test.
pageinspect has occasionally failed on slow buildfarm members, with symptoms indicating that the expected effects of VACUUM FREEZE didn't happen. This is presumably because a background transaction such as auto-analyze was holding back global xmin. We can work around that by using a temp table in the test. Since commit a7212be, that will use an up-to-date cutoff xmin regardless of other processes. And pageinspect itself shouldn't really care whether the table is temp. Back-patch to v14. There would be no point in older branches without back-patching a7212be, which seems like more trouble than the problem is worth. Discussion: https://postgr.es/m/2892135.1668976646@sss.pgh.pa.us
1 parent a0d35eb commit ff9d27e

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

contrib/pageinspect/expected/page.out

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
CREATE EXTENSION pageinspect;
2-
CREATE TABLE test1 (a int, b int);
2+
-- Use a temp table so that effects of VACUUM are predictable
3+
CREATE TEMP TABLE test1 (a int, b int);
34
INSERT INTO test1 VALUES (16777217, 131584);
45
VACUUM (DISABLE_PAGE_SKIPPING) test1; -- set up FSM
56
-- The page contents can vary, so just test that it can be read

contrib/pageinspect/sql/page.sql

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
CREATE EXTENSION pageinspect;
22

3-
CREATE TABLE test1 (a int, b int);
3+
-- Use a temp table so that effects of VACUUM are predictable
4+
CREATE TEMP TABLE test1 (a int, b int);
45
INSERT INTO test1 VALUES (16777217, 131584);
56

67
VACUUM (DISABLE_PAGE_SKIPPING) test1; -- set up FSM

0 commit comments

Comments
 (0)