Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 0dba54f

Browse files
committed
Remove user_relns() SRF from regression tests.
The output of the function changes whenever previous (or, as in this case, concurrent) tests leave a table in place. That causes unneeded churn. This should fix failures due to the tests added bfe16d1, like on lapwing, caused by the tsrf test running concurrently with misc. Those could also have been addressed by using temp tables, but that test has annoyed me before. Discussion: <27626.1473729905@sss.pgh.pa.us>
1 parent 9f478b4 commit 0dba54f

File tree

4 files changed

+0
-158
lines changed

4 files changed

+0
-158
lines changed

src/test/regress/input/create_function_2.source

-9
Original file line numberDiff line numberDiff line change
@@ -62,15 +62,6 @@ CREATE FUNCTION equipment_named_ambiguous_2b(hobby text)
6262
LANGUAGE SQL;
6363

6464

65-
CREATE FUNCTION user_relns()
66-
RETURNS setof name
67-
AS 'select relname
68-
from pg_class c, pg_namespace n
69-
where relnamespace = n.oid and
70-
(nspname !~ ''pg_.*'' and nspname <> ''information_schema'') and
71-
relkind <> ''i'' '
72-
LANGUAGE SQL;
73-
7465
CREATE FUNCTION pt_in_widget(point, widget)
7566
RETURNS bool
7667
AS '@libdir@/regress@DLSUFFIX@'

src/test/regress/input/misc.source

-3
Original file line numberDiff line numberDiff line change
@@ -218,9 +218,6 @@ SELECT (p.hobbies).equipment.name, name(p.hobbies), p.name FROM ONLY person p;
218218

219219
SELECT name(equipment(p.hobbies)), name(p.hobbies), p.name FROM person* p;
220220

221-
SELECT user_relns() AS user_relns
222-
ORDER BY user_relns;
223-
224221
SELECT name(equipment(hobby_construct(text 'skywalking', text 'mer')));
225222

226223
SELECT name(equipment(hobby_construct_named(text 'skywalking', text 'mer')));

src/test/regress/output/create_function_2.source

-8
Original file line numberDiff line numberDiff line change
@@ -47,14 +47,6 @@ CREATE FUNCTION equipment_named_ambiguous_2b(hobby text)
4747
RETURNS setof equipment_r
4848
AS 'select * from equipment_r where equipment_r.hobby = hobby'
4949
LANGUAGE SQL;
50-
CREATE FUNCTION user_relns()
51-
RETURNS setof name
52-
AS 'select relname
53-
from pg_class c, pg_namespace n
54-
where relnamespace = n.oid and
55-
(nspname !~ ''pg_.*'' and nspname <> ''information_schema'') and
56-
relkind <> ''i'' '
57-
LANGUAGE SQL;
5850
CREATE FUNCTION pt_in_widget(point, widget)
5951
RETURNS bool
6052
AS '@libdir@/regress@DLSUFFIX@'

src/test/regress/output/misc.source

-138
Original file line numberDiff line numberDiff line change
@@ -574,144 +574,6 @@ SELECT name(equipment(p.hobbies)), name(p.hobbies), p.name FROM person* p;
574574
peet's coffee | posthacking | jeff
575575
(6 rows)
576576

577-
SELECT user_relns() AS user_relns
578-
ORDER BY user_relns;
579-
user_relns
580-
---------------------
581-
a
582-
a_star
583-
abstime_tbl
584-
aggtest
585-
aggtype
586-
array_index_op_test
587-
array_op_test
588-
arrtest
589-
b
590-
b_star
591-
box_tbl
592-
bprime
593-
brinopers
594-
brintest
595-
bt_f8_heap
596-
bt_i4_heap
597-
bt_name_heap
598-
bt_txt_heap
599-
btree_tall_tbl
600-
c
601-
c_star
602-
char_tbl
603-
check2_tbl
604-
check_seq
605-
check_tbl
606-
circle_tbl
607-
city
608-
copy_tbl
609-
d
610-
d_star
611-
date_tbl
612-
default_seq
613-
default_tbl
614-
defaultexpr_tbl
615-
dept
616-
dupindexcols
617-
e_star
618-
emp
619-
equipment_r
620-
f_star
621-
fast_emp4000
622-
float4_tbl
623-
float8_tbl
624-
func_index_heap
625-
gin_test_tbl
626-
gist_point_tbl
627-
hash_f8_heap
628-
hash_i4_heap
629-
hash_name_heap
630-
hash_txt_heap
631-
hobbies_r
632-
iexit
633-
ihighway
634-
inet_tbl
635-
inhf
636-
inhx
637-
insert_seq
638-
insert_tbl
639-
int2_tbl
640-
int4_tbl
641-
int8_tbl
642-
interval_tbl
643-
iportaltest
644-
kd_point_tbl
645-
line_tbl
646-
log_table
647-
lseg_tbl
648-
main_table
649-
money_data
650-
mvtest_bb
651-
mvtest_t
652-
mvtest_tm
653-
mvtest_tmm
654-
mvtest_tv
655-
mvtest_tvm
656-
mvtest_tvmm
657-
mvtest_tvv
658-
mvtest_tvvm
659-
mvtest_tvvmv
660-
num_data
661-
num_exp_add
662-
num_exp_div
663-
num_exp_ln
664-
num_exp_log10
665-
num_exp_mul
666-
num_exp_power_10_ln
667-
num_exp_sqrt
668-
num_exp_sub
669-
num_input_test
670-
num_result
671-
onek
672-
onek2
673-
path_tbl
674-
person
675-
point_tbl
676-
polygon_tbl
677-
quad_point_tbl
678-
radix_text_tbl
679-
ramp
680-
random_tbl
681-
real_city
682-
reltime_tbl
683-
rls_tbl
684-
rls_tbl_force
685-
road
686-
shighway
687-
slow_emp4000
688-
spgist_point_tbl
689-
spgist_text_tbl
690-
street
691-
stud_emp
692-
student
693-
subselect_tbl
694-
tenk1
695-
tenk2
696-
test_range_excl
697-
test_range_gist
698-
test_range_spgist
699-
test_tablesample
700-
test_tablesample_v1
701-
test_tablesample_v2
702-
test_tsvector
703-
testjsonb
704-
text_tbl
705-
time_tbl
706-
timestamp_tbl
707-
timestamptz_tbl
708-
timetz_tbl
709-
tinterval_tbl
710-
toyemp
711-
varchar_tbl
712-
xacttest
713-
(132 rows)
714-
715577
SELECT name(equipment(hobby_construct(text 'skywalking', text 'mer')));
716578
name
717579
------

0 commit comments

Comments
 (0)