Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 0e2c85d

Browse files
committed
Fix pgbench's failure to honor the documented long-form option "--builtin".
Not only did it not accept --builtin as a synonym for -b, but what it did accept as a synonym was --tpc-b (huh?), which it got even further wrong by marking as no_argument, so that if you did try that you got a core dump. I suppose this is leftover from some early design for the new switches added by commit 8bea3d2, but it's still pretty sloppy work. Per bug #14580 from Stepan Pesternikov. Back-patch to 9.6 where the error was introduced. Report: https://postgr.es/m/20170307123347.25054.73207@wrigleys.postgresql.org
1 parent e961341 commit 0e2c85d

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/bin/pgbench/pgbench.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -3369,7 +3369,7 @@ main(int argc, char **argv)
33693369
{
33703370
static struct option long_options[] = {
33713371
/* systematic long/short named options */
3372-
{"tpc-b", no_argument, NULL, 'b'},
3372+
{"builtin", required_argument, NULL, 'b'},
33733373
{"client", required_argument, NULL, 'c'},
33743374
{"connect", no_argument, NULL, 'C'},
33753375
{"debug", no_argument, NULL, 'd'},

0 commit comments

Comments
 (0)